Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default args and type hints for Project Euler problem 7 #2973

Open
wants to merge 1 commit into
base: master
from
Open

Add default args and type hints for Project Euler problem 7 #2973

wants to merge 1 commit into from
+49 −32

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 7, 2020

Continuing #2786

  • Add default argument values
  • Add type hints
  • Change one letter variable names to a more descriptive one
  • Add doctest for solution()

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
@dhruvmanila
Add default args and type hints for problem 7
Verified
This commit was signed with a verified signature.
dhruvmanila Dhruv
GPG key ID: 9601911DE8797432 Learn about signing commits
Loading status checks…
26a797d 
- Add default argument values
- Add type hints
- Change one letter variable names to a more descriptive one
- Add doctest for `solution()`
@dhruvmanila dhruvmanila requested review from Kush1101 and shellhub Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellhub shellhub

@Kush1101 Kush1101

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Need Reviews
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@dhruvmanila
You can’t perform that action at this time.