Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream @ 181cc781 #16

Open
wants to merge 187 commits into
base: master
from
Open

Conversation

@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 5, 2020

This PR was automatically generated to merge changes from en.javascript.info at 181cc78

Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.

Alternatively, you can close this PR and merge conflicting changes manually.

The following files have conflicts and may need updates of the translations:

To merge changes manually (instead of merging this PR):

  1. Add remote upstream that links to the English version (only needs to be done once)
    • git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
  2. Commit all current work locally and git checkout master
  3. Pull the recent changes from the English version:
    • git pull upstream master
  4. Deal with the conflicts. If a conflict touches a few lines, then just fix it. Otherwise, following commands can help:
    • Checkout your (translated) version of a file/folder at the given path (removes all upstream changes):
      • git checkout --ours <path>
    • See the diff, what changed in the upstream file since branches diverged:
      • git diff --word-diff master...upstream/master <path> (please note: three dots in the command)
    • Then you can examine the changes in upstream and add them manually
  5. When conflicts resolved, commit them and git push origin master

This PR will be closed and replaced with a new one in a few days.

paroche and others added 30 commits Feb 7, 2020
My proposed change may not be right, but "make a request to URL" was unclear, and it's `fetch` that's used below to make the request. If 'request to URL' has some special meaning and is what you want to say, maybe some rephrasing is in order.
"// obj.toString === obj.__proto__.toString == Object.prototype.toString"
It is look like JS code but it gives different result from what we want to get.
There is different kind of equality operator ant these give more confusing what is the purpose of these?
It can be better to separate this line into 2 line of code to make it sensible and readable.
Subject and code is already hard but there is no need to make readers ask unnecessary questions.
Aiyo
An interesting question may arise in the example above: what’s the value of this inside set fullName(value)? Where are the properties this.name and this.surname written: into user or admin?

The answer is simple: this is not affected by prototypes at all.

No matter where the method is found: in an object or its prototype. In a method call, this is always the object before the dot.

So, the setter call admin.fullName= uses admin as this, not user.

That is actually a super-important thing, because we may have a big object with many methods, and have objects that inherit from it. And when the inheriting objects run the inherited methods, they will modify only their own states, not the state of the big object.

The example code doesn't show these concepts. Also, these additions can make readers ask questions before the explanation of the example code.
Small fixes.
Added link to Brython Python transpiler to JavaScript
add semicolon 13,20 line
Explained how to create a date object.
iliakan and others added 27 commits Sep 23, 2020
Knowledge correcting: Delete "Trident"
Dynamic script document order execution is done with async=false
Fix old link and excess line break in 1.2.8
Fix grammar and construction in 2.1.10
PR for issues/2119
Add Edge to list of V8-powered browsers
Changed "position" to "index" for slice() method
Address some possible inconsistencies in 1.2.9
Fix typo in 1.2.12
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-ml Oct 5, 2020
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Oct 5, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 15 committers have signed the CLA.

iliakan
leviding
Isildur46
vsemozhetbyt
joaquinelio
Jarvis-3000
MuhammedZakir
apcurran
cristian-wang
amit1702
zzy0302
peachesontour
Ruslan-Aleev
shanesc
galacemiguel
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.