Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sleep sort #2956

Open
wants to merge 6 commits into
base: master
from
Open

Sleep sort #2956

wants to merge 6 commits into from
+63 −0

Conversation

@EkanshdeepGupta
Copy link

@EkanshdeepGupta EkanshdeepGupta commented Oct 7, 2020

Describe your change:

Added sleep_sort algorithm.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@EkanshdeepGupta
adding sort/sleep_sort.py
7ce5cd0
@EkanshdeepGupta
converted tabs to spaces
958d58b
@EkanshdeepGupta
add reference
Loading status checks…
d650def
@EkanshdeepGupta
corrected typo in main
Loading status checks…
83aa113
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 7, 2020

Travis tests have failed

Hey @EkanshdeepGupta,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8b21a0c0-0843-11eb-9b15-83942378e0dd
@EkanshdeepGupta
corrected typo in main
4985baa
@EkanshdeepGupta
Copy link
Author

@EkanshdeepGupta EkanshdeepGupta commented Oct 7, 2020 •
edited

Please help me understand why the pre-commit check is failing. I am unable to understand by looking at the details. Similarly, I cannot understand why the Travis CI is failing.
@EkanshdeepGupta
handled case of empty collection
Loading status checks…
40a41c3
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 7, 2020

Travis tests have failed

Hey @EkanshdeepGupta,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a36e4d60-0846-11eb-9b15-83942378e0dd
@EkanshdeepGupta
Copy link
Author

@EkanshdeepGupta EkanshdeepGupta commented Oct 7, 2020

By the looks of it, the Travis CI is failing because of an unrelated file, ciphers/affine_cipher.py. Since my code has nothing to do with that, I believe my request should be approved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@EkanshdeepGupta @TravisBuddy
You can’t perform that action at this time.