Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove translations/*/content/README.md #256

Merged
merged 2 commits into from Oct 8, 2020

Conversation

@shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented Oct 8, 2020

Why:

Some translated documents have content/README.md (but not all).
These files are ignored by crowdin.yml, so they are never updated by the Crowdin integration.

"/content/README.md"

I think that these files were committed by mistake.
They confuse us because they keep holding on to old information.

What's being changed:

I removed them.

Check off the following:

@shogo82148 shogo82148 requested a review from github/docs-localization as a code owner Oct 8, 2020
@welcome
Copy link

@welcome welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@deploy-to-heroku deploy-to-heroku bot temporarily deployed to docs-256--remove-translations Oct 8, 2020 Inactive
@github-actions github-actions bot added this to Triage in Docs team reviews Oct 8, 2020
@zeke
zeke approved these changes Oct 8, 2020
Copy link
Member

@zeke zeke left a comment

Thanks for the contribution @shogo82148. Those README files are supposed to by ignored by our Crowdin integration but it looks like they slipped through the cracks at some point.

I'll merge this when all checks are passing.

@zeke zeke merged commit 6cebc9a into github:main Oct 8, 2020
11 checks passed
11 checks passed
triage
Details
automerge
Details
automerge
Details
lint
Details
test (content)
Details
test (meta)
Details
test (rendering)
Details
test (routing)
Details
test (unit)
Details
test (links-and-images)
Details
staging deployed in 80 seconds
Details
Docs team reviews automation moved this from Triage to Done Oct 8, 2020
@shogo82148 shogo82148 deleted the shogo82148:remove-translations-content-readme branch Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.