Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying lossless compression to unoptimized png files in images #299

Merged
merged 2 commits into from Oct 9, 2020

Conversation

@Protectator
Copy link
Contributor

@Protectator Protectator commented Oct 8, 2020

Why:

This PR aims to solve #298.

What's being changed:

I optimized the size of PNGs in the assets/images by using lossless compression algorithm on them. The new size of the optimized PNGs in this PR vary between 49% and 93% of their original size. This PR reduces the total size of the images by ~2457 KB.

Check off the following:

@welcome
Copy link

@welcome welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@deploy-to-heroku deploy-to-heroku bot temporarily deployed to docs-299--optimize-png Oct 8, 2020 Inactive
@github-actions github-actions bot added this to Triage in Docs team reviews Oct 8, 2020
@heiskr
heiskr approved these changes Oct 9, 2020
Copy link
Contributor

@heiskr heiskr left a comment

🙏🏼 Thanks!

@heiskr heiskr merged commit a837658 into github:main Oct 9, 2020
11 checks passed
11 checks passed
triage
Details
automerge
Details
run run
Details
lint
Details
test (content)
Details
test (meta)
Details
test (rendering)
Details
test (routing)
Details
test (unit)
Details
test (links-and-images)
Details
staging deployed in 75 seconds
Details
Docs team reviews automation moved this from Triage to Done Oct 9, 2020
@Protectator Protectator deleted the Protectator:optimize-png branch Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.