Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[Project Euler] Algorithms do not follow coding styles #2786
Comments
UPDATE: As this is getting closer and closer to being fixed and the number of files per directory is reducing, you can create a PR fixing files in maximum 2 directories.This is a completely valid issue. The thing is:
Now as the number of solutions is increasing we need to enforce some of the consistency. One of the main ones was as I mentioned in #2695 (comment) but as you said there are many more. We can start with this and fix one issue at a time. Due to some of the solutions not containing Submit the fix for These are the errors which need to be fixed before we can start running the script in our tests: These two are the main messages to look for in the above log:
Current Status:
|
* fix code style in problem 76 Signed-off-by: joan.rosellr <joan.rosellr@gmail.com> * Update sol1.py * Update sol1.py * Remove trailing whitespace Co-authored-by: Dhruv <dhruvmanila@gmail.com>
|
@dhruvmanila Is the task list up to date? |
* name method solution in project_euler/problem99 * rename function
|
@M-Smits Yes, but keep in mind that the task list only removes a fix if it's merged. It might be the case that the fix is present in the list but someone already opened a PR, you have to confirm that yourself. |
|
@dhruvmanila I'm a beginner in Python and would love to contribute. Could you please guide me with any of the issues and I'll take it from there? |
|
I would like to work on this in python. kindly assign me this work. |
Many algorithms in Project Euler do not follow coding styles as mentioned by @dhruvmanila here, or even the standard coding guidelines.
Notes:
solutionfunctions (a lot of them aren't named as "solution")But there are places where this isn't practised.
Python/project_euler/problem_30/soln.py
Line 36 in b934da4
Python/project_euler/problem_01/sol1.py
Line 9 in b934da4
Python/project_euler/problem_01/sol2.py
Line 9 in b934da4
The list isn't complete.
As a beginner who's looking to either understand/contribute, this makes it a bit difficult.