Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional cleanup step after failover to HA replica #252

Open
wants to merge 1 commit into
base: main
from

Conversation

@mwiesen
Copy link
Contributor

@mwiesen mwiesen commented Oct 8, 2020

Why:

With the current documentation a failover will be completed and access to the GitHub Enterprise Server will be restored, however a configuration cleanup will not be performed.

This means that Spokes, DPages, and Storage will maintain references to the old (potentially inaccessible) servers yet will be unable to replicate any data to them. This can and will eventually lead to clone/push failures and full repository outages should those servers not be re-added as replicas.

Solves github/docs-content#2564

What's being changed:

Our current documentation outlines the high-level steps to perform a failover, however more detail is needed clarifying follow-up actions in the event that that the primary server and/or other replicas will not be re-added to the GitHub Enterprise Server configuration.

I added a new (optional) step following the current step 7 noting the UUIDs of any servers which will not be re-added to the environment should be cleaned up by running ghe-repl-teardown -u <uuid_here>.

Check off the following:

@maclarel
@myarb

@welcome
Copy link

@welcome welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@mwiesen mwiesen requested a review from myarb Oct 8, 2020
@mwiesen mwiesen self-assigned this Oct 8, 2020
@github-actions github-actions bot added this to Triage in Docs team reviews Oct 8, 2020
@mwiesen mwiesen added the content label Oct 8, 2020
@janiceilene
Copy link
Contributor

@janiceilene janiceilene commented Oct 8, 2020

Thanks for opening a PR @mwiesen! I'll let the @github/docs-content-core team know it's ready for review 💝

@janiceilene janiceilene added the core label Oct 8, 2020
@janiceilene janiceilene moved this from Triage to Core in Docs team reviews Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.