Skip to content

/ docs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ed25519 keys instead of rsa keys #362

Open
wants to merge 1 commit into
base: main
from
Open

use ed25519 keys instead of rsa keys #362

wants to merge 1 commit into from

Conversation

@timball
Copy link

@timball timball commented Oct 9, 2020 •
edited

RSA keys are outdated. Even by using larger 4096 keys maybe it's best to move away from rsa keys altogether.

This PR updates the document to suggest using ed25519 keys which, at this time, defaults to a 16 round key deviation function. It may be useful to suggest more rounds for the KDF but that's for a different PR.

--timball

Why:

What's being changed:

Check off the following:
@timball
use ed25519 keys instead of rsa keys
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
62bcdb4 
RSA keys are outdated. Even by using larger 4096 keys maybe it's best to move away from rsa keys altogether. 

This PR updates the document to suggest using ed25519 keys which, at this time, defaults to a 16 round key deviation function. It may be useful to suggest more rounds for the KDF but that's for a different PR. 

--timball
@welcome
Copy link

@welcome welcome bot commented Oct 9, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
@github-actions github-actions bot added this to Triage in Docs team reviews Oct 9, 2020
@janiceilene
Copy link
Contributor

@janiceilene janiceilene commented Oct 9, 2020

Thanks for opening a PR 👍 Please fill out the pull request template and we'll get this up for review!
@timball
Copy link
Author

@timball timball commented Oct 9, 2020

Thanks for opening a PR 👍 Please fill out the pull request template and we'll get this up for review!

Is the pull request template the same as filing a bug report? If not where do I find the template? Please and thank you.

https://github.com/github/docs/issues/new?assignees=&labels%5B%5D=content&template=improve-existing-docs.md&title=

--timball
@janiceilene
Copy link
Contributor

@janiceilene janiceilene commented Oct 9, 2020

👋 @timball The pull request template is the information in the original comment at the top of this pull request (the Why? and What's changed?). You can see all of the text in the pull-request.md. It helps us to triage and choose the right reviewer for each PR that's opened. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Docs team reviews
Triage
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@timball @janiceilene
You can’t perform that action at this time.