Skip to content

/ web-php

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace http:// to https:// #287

Open
wants to merge 18 commits into
base: master
from
Open

Replace http:// to https:// #287

wants to merge 18 commits into from

Conversation

@dusta
Copy link

@dusta dusta commented Jun 19, 2019

Change of important links
dusta added 10 commits Jun 19, 2019
@dusta
Replace http://www.php.net to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
98474fd
@dusta
Replace http://bugs.php.net to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
aedfd4c
@dusta
Replace http://pear.php.net to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
df1ac24
@dusta
Replace http://php.net to https and with www
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
90546d5
@dusta
Replace http://wiki.php.net to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
8c98467
@dusta
Replace http://git.php.net to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
3d2b692
@dusta
Replace http://git-scm.com to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
67de2c6
@dusta
Replace http://github.com to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
047251c
@dusta
Replace http://pecl.php.net/ to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
de4925c
@dusta
Replace http://www.php.net/ to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
f61cc4d
@petk
Copy link
Contributor

@petk petk commented Jun 20, 2019

Thanks for this patch. Luckily, I think the PHPeople are now finally ready for such changes because I too think that they are really important for 2019:
php/php-src#3775

Not using (and promoting) https is like living in the past... Thumbs up @dusta 👍
@petk
Copy link
Contributor

@petk petk commented Jun 20, 2019

https://bugs.php.net/bug.php?id=74126

https://bugs.php.net/bug.php?id=67680

https://bugs.php.net/bug.php?id=78137

https://bugs.php.net/bug.php?id=76831

https://bugs.php.net/bug.php?id=78037

:)
@dusta
Copy link
Author

@dusta dusta commented Jun 20, 2019 •
edited

With this links should not be problems. I have checked and they have forcing redirect to https. There is more in the code http but on php.net is not supported like for example http://docs.php.net/manual/ so I haven't change that.
@salathe
Copy link
Contributor

@salathe salathe commented Jun 20, 2019

Thanks for this @dusta! There are a bunch of other php.net sites that look to support HTTPS, would you mind updating references to these as well?

  • downloads.php.net
  • edit.php.net
  • master.php.net
  • museum.php.net
  • people.php.net
  • qa.php.net
  • svn.php.net
  • windows.php.net
dusta added 6 commits Jun 20, 2019
@dusta
Replace http://downloads.php.net to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
64add65
@dusta
Replace http://edit.php.net to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
f7bf407
@dusta
Replace http://master.php.net to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
50b5e76
@dusta
Replace http://museum.php.net to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
d9c3f34
@dusta
Replace http://people.php.net to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
edcfbe4
@dusta
Replace http://qa.php.net to https
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
8a41a5d
@dusta
Copy link
Author

@dusta dusta commented Jun 20, 2019

svn.php.net is not supported
@salathe
Copy link
Contributor

@salathe salathe commented Jun 21, 2019

svn.php.net is not supported

What do you mean by this?
@dusta
Copy link
Author

@dusta dusta commented Jun 21, 2019

svn.php.net is not supported

What do you mean by this?

Interesting... Yesterday https did not work. Can you confirm if everything is alright?
@salathe
Copy link
Contributor

@salathe salathe commented Jun 25, 2019

Can you confirm if everything is alright?

I confirm that everything is alright. 😊
@dusta
Replace http://svn.php.net to https
e70bc65
@ramsey
Copy link
Contributor

@ramsey ramsey commented Mar 6, 2020

Is there anything left to do for this PR (besides resolving the conflicts) before it can be merged?
@salathe
Copy link
Contributor

@salathe salathe commented Mar 7, 2020

Is there anything left to do for this PR (besides resolving the conflicts) before it can be merged?

Not that I'm aware of.

@dusta Can you resolve the conflicts on top of current master? It would also be nice if you could squash the 17 commits into 1 big commit at the same time.
@dusta
Copy link
Author

@dusta dusta commented Mar 9, 2020

@salathe I will try it
@dusta
Merge branch 'master' of https://github.com/php/web-php
Verified
This commit was signed with a verified signature.
dusta Sławomir Kaleta
GPG key ID: D6C83216CEF85693 Learn about signing commits
7e5db52 
# Conflicts:
#README.md
#bin/createNewsEntry
#conferences/index.php
#index.php
#releases/index.php
@cmb69 cmb69 mentioned this pull request May 25, 2020
Closed
@caugner
Copy link

@caugner caugner commented May 25, 2020

@salathe Wouldn't it be easier to just git merge --squash this branch into master manually or using the GitHub UI?
@cmb69
Copy link
Contributor

@cmb69 cmb69 commented May 25, 2020

The merge conflicts have been resolved long ago. :)
@caugner
Copy link

@caugner caugner commented May 25, 2020

@cmb69 What exactly is blocking the merge then? :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@dusta @petk @salathe @ramsey @caugner @cmb69
You can’t perform that action at this time.