Skip to content

/ ar.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document #85

Open
wants to merge 26 commits into
base: master
from
Open

document #85

wants to merge 26 commits into from

Conversation

@abdelrhmanali29
Copy link

@abdelrhmanali29 abdelrhmanali29 commented Jun 15, 2020

No description provided.

abdelrhman_ali
translate Browser environment, specs into AR
Loading status checks…
506c67d
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-ar Jun 15, 2020
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jun 15, 2020 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ 3imed-jaberi
✅ abdelrhmanali29
❌ abdelrhman_ali

abdelrhman_ali seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
@3imed-jaberi 3imed-jaberi self-assigned this Jun 18, 2020
@3imed-jaberi
3imed-jaberi requested changes Jun 18, 2020
View changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

@abdelrhmanali29, thank u for your contribution 😄
plz, check my suggestions 💯 !!
2-ui/1-document/01-browser-environment/article.md Outdated Show resolved Hide resolved
2-ui/1-document/01-browser-environment/article.md Outdated Show resolved Hide resolved
2-ui/1-document/01-browser-environment/article.md Outdated Show resolved Hide resolved
2-ui/1-document/01-browser-environment/article.md Show resolved Hide resolved
2-ui/1-document/01-browser-environment/article.md Outdated Show resolved Hide resolved
2-ui/1-document/01-browser-environment/article.md Outdated Show resolved Hide resolved
2-ui/1-document/01-browser-environment/article.md Outdated Show resolved Hide resolved
2-ui/1-document/01-browser-environment/article.md Outdated Show resolved Hide resolved
2-ui/1-document/01-browser-environment/article.md Outdated Show resolved Hide resolved
2-ui/1-document/01-browser-environment/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jun 18, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
abdelrhmanali29 and others added 21 commits Jun 20, 2020
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f96a1ee 
editing

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7d8ba68 
editing some words

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c14cae8 
editing some words

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c818367 
editing some words

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
71c905b 
editing some words

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
915c144 
remove line

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
11e2e8c 
remove line

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
70264ea 
editing some words

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4e22724 
editing some words

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
141ff31 
editing some words

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9e8ee3e 
remove Parentheses

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0f67bde 
remove space

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
880c04a 
Adding ال

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b9634e6 
editing some words

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3f2a0ba 
remove spaces

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2d0783d 
remove "them"

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4fd430e 
removing spaces

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Update 2-ui/1-document/01-browser-environment/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9d9da89 
Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Update 2-ui/1-document/01-browser-environment/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0b38987 
Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Update 2-ui/1-document/01-browser-environment/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c3921ad 
remove line

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Update 2-ui/1-document/01-browser-environment/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
69b18a9 
remove space and add ال

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
abdelrhmanali29 and others added 2 commits Jun 20, 2020
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
333982c 
edit some words

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29 @3imed-jaberi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
52c25f0 
edit some words and symbols

Co-authored-by: imed jaberi <imed_jebari@hotmail.fr>
@abdelrhmanali29
abdelrhmanali29 reviewed Jun 20, 2020
View changes
Copy link
Author

@abdelrhmanali29 abdelrhmanali29 left a comment

@3imed-jaberi
Thank you for your reviewing
2-ui/1-document/01-browser-environment/article.md Show resolved Hide resolved
@abdelrhmanali29 abdelrhmanali29 requested a review from 3imed-jaberi Jun 20, 2020
@3imed-jaberi
3imed-jaberi reviewed Jun 21, 2020
View changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment •
edited

@abdelrhmanali29
ممكن تعوض كل كلمة موجودة في ترجمة بكلمة JavaScript ..
ارجو منك ان تكتبها بهذا الشكل JavaScript و ليس هكذا javascript
3imed-jaberi added 2 commits Jul 6, 2020
@3imed-jaberi
Merge branch 'master' into document
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0939b60
@3imed-jaberi
Merge branch 'master' into document
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f352c57
@3imed-jaberi
3imed-jaberi requested changes Jul 12, 2020
View changes
2-ui/1-document/01-browser-environment/article.md Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 12, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@abdelrhmanali29
Copy link
Author

@abdelrhmanali29 abdelrhmanali29 commented Aug 1, 2020 •
edited

@3imed-jaberi
It's done
and changes committed
What should I do now?
@atefBB
Copy link
Contributor

@atefBB atefBB commented Aug 3, 2020

@abdelrhmanali29
There's one change requested from @3imed-jaberi not resolved, resolve it and them comment this "/done".
@abdelrhmanali29 abdelrhmanali29 requested a review from 3imed-jaberi Aug 3, 2020
@abdelrhmanali29
Copy link
Author

@abdelrhmanali29 abdelrhmanali29 commented Aug 3, 2020

/done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3imed-jaberi 3imed-jaberi

Assignees

@atefBB atefBB

@3imed-jaberi 3imed-jaberi

Labels
review needed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@abdelrhmanali29 @CLAassistant @javascript-translate-bot @atefBB @3imed-jaberi
You can’t perform that action at this time.