Skip to content

/ ionic-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(animation): cubic-bezier easing conversion utility (experimental) #19788

Merged
merged 6 commits into from Oct 31, 2019
Merged

feat(animation): cubic-bezier easing conversion utility (experimental) #19788

merged 6 commits into from Oct 31, 2019

Conversation

@liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Oct 29, 2019 •
edited

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19789

What is the new behavior?

  • Exposed a utility to convert time from easing curve A to easing curve B

Does this introduce a breaking change?

  • Yes
  • No

Other information
liamdebeasi added 2 commits Oct 29, 2019
@liamdebeasi
expose easing uti
Loading status checks…
57b4eb4
@liamdebeasi
Merge remote-tracking branch 'origin/master' into expose-easing
4f3df30
liamdebeasi added 4 commits Oct 30, 2019
@liamdebeasi
update angular controller
Loading status checks…
75f11a3
@liamdebeasi
expose angular controller easing
Loading status checks…
2549866
@liamdebeasi
fix typo
Loading status checks…
19fe0f5
@liamdebeasi
run linter
Loading status checks…
c937da5
@liamdebeasi liamdebeasi marked this pull request as ready for review Oct 30, 2019
@liamdebeasi liamdebeasi merged commit 96a5e60 into master Oct 31, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
@liamdebeasi liamdebeasi deleted the expose-easing branch Oct 31, 2019
@liamdebeasi liamdebeasi added this to In progress 🤺 in Ionic Core via automation Oct 31, 2019
@liamdebeasi liamdebeasi moved this from In progress 🤺 to Done 🎉 in Ionic Core Oct 31, 2019
mhartington added a commit that referenced this pull request Oct 31, 2019
@liamdebeasi @mhartington
feat(animation): cubic-bezier easing conversion utility (experimental) (
Verified
This commit was signed with a verified signature.
mhartington Mike Hartington
GPG key ID: 493BFB24814E6209 Learn about signing commits
3fba828 
#19788)

resolves #19789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core
Projects
Ionic Core
  
Done 🎉
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@liamdebeasi
You can’t perform that action at this time.