Skip to content

/ mysqlclient-python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove py27 support from Python sources. #394

Merged
merged 8 commits into from Nov 28, 2019
Merged

Remove py27 support from Python sources. #394

merged 8 commits into from Nov 28, 2019

Conversation

@Djailla
Copy link
Contributor

@Djailla Djailla commented Nov 6, 2019 •
edited by methane

No description provided.

@Djailla Djailla force-pushed the Djailla:py27 branch from 3b80aab to f32e0da Nov 6, 2019
@methane
Copy link
Member

@methane methane commented Nov 7, 2019

I remove Python 2 support after 2020-01-01.
Bastien Vallet
[compat] Remove py27 support as Python 2.7 will be deprecated beginni…
Loading status checks…
98652bb 
…ng of 2020
@Djailla Djailla force-pushed the Djailla:py27 branch from f32e0da to 98652bb Nov 7, 2019
@methane methane added this to the v2.0 milestone Nov 18, 2019
methane added 6 commits Nov 28, 2019
@methane
Update connections.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e088377
@methane
Update converters.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
67f7410
@methane
Update converters.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
991a52f
@methane
Update connections.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
992fa4d
@methane
Update cursors.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ac4aa89
@methane
Update connections.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d9fd4f0
@methane methane changed the title [compat] Remove py27 support as Python 2.7 will be deprecated beginni… Remove py27 support from Python sources. Nov 28, 2019
@methane
Update test_MySQLdb_nonstandard.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
34399d3
@codecov
Copy link

@codecov codecov bot commented Nov 28, 2019 •
edited

Codecov Report

Merging #394 into master will decrease coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   86.98%   86.64%   -0.35%     
==========================================
  Files          13       12       -1     
  Lines        1560     1535      -25     
==========================================
- Hits         1357     1330      -27     
- Misses        203      205       +2
Impacted Files Coverage Δ
MySQLdb/cursors.py 80.84% <100%> (-0.15%) ⬇️
MySQLdb/_exceptions.py 100% <100%> (ø) ⬆️
MySQLdb/connections.py 80.28% <100%> (-2.04%) ⬇️
MySQLdb/converters.py 82.35% <100%> (-0.51%) ⬇️
MySQLdb/__init__.py 83.33% <100%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a75ea...34399d3. Read the comment docs.
@methane methane merged commit 026e87f into PyMySQL:master Nov 28, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 86.98%)
Details
codecov/project Absolute coverage decreased by -0.34% but relative coverage increased by +13.01% compared to 17a75ea
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@methane
Copy link
Member

@methane methane commented Nov 28, 2019

thanks
@Djailla Djailla deleted the Djailla:py27 branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Djailla @methane
You can’t perform that action at this time.