Skip to content

Conversation

@juristr
Copy link
Contributor

@juristr juristr commented May 25, 2020

The current README is out of date as it still refers to running tests with node. Instead the package.json scripts have been modified to use Bazel instead.

Running them with node isn't working any more. Bazel has to be used
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels May 26, 2020
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juristr, thanks for this.

Can you please make the changes here instead https://github.com/angular/angular-cli/blob/master/scripts/templates/readme.ejs and run yarn admin templates

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 26, 2020
@juristr
Copy link
Contributor Author

juristr commented May 26, 2020

@alan-agius4 oh I see. Will do later 👍

@cexbrayat
Copy link
Member

@juristr 👍 Awesome!

I think it would be great to also showcase how you can run only some of the tests, as the full build takes forever.
I'm using yarn bazel test //packages/angular_devkit/build_angular:build_angular_browser_test for example but maybe someone has an even better command than this? Is there a way to have even more granularity? When you want to make a small contribution, and run just one spec, it would be great to find how to do it in the README.

@juristr juristr closed this Jun 1, 2020
@juristr juristr reopened this Jun 1, 2020
@juristr
Copy link
Contributor Author

juristr commented Jun 1, 2020

@cexbrayat agree, unfortunately I don't either. Didn't look into it. I just had to run the tests myself and found the outdated readme, which is why I went and submitted this PR :)

Maybe @alan-agius4 knows 🙂

@alan-agius4 I'm gonna fix this PR in the coming days

@alan-agius4
Copy link
Collaborator

You can use the standard jasmine methods fit and fdescribe.

@cexbrayat
Copy link
Member

@alan-agius4 Might be worth adding to the README, but Bazel will still download and compile everything no? yarn bazel test //packages/angular_devkit/build_angular:build_angular_browser_test might be worth mentionning as it "just" compile the package you try to test?

@alan-agius4
Copy link
Collaborator

Closing as this should be already fixed on master.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants