-
Notifications
You must be signed in to change notification settings - Fork 11.9k
docs: README info about running tests #17787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Running them with node isn't working any more. Bazel has to be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juristr, thanks for this.
Can you please make the changes here instead https://github.com/angular/angular-cli/blob/master/scripts/templates/readme.ejs and run yarn admin templates
|
@alan-agius4 oh I see. Will do later 👍 |
|
@juristr 👍 Awesome! I think it would be great to also showcase how you can run only some of the tests, as the full build takes forever. |
|
@cexbrayat agree, unfortunately I don't either. Didn't look into it. I just had to run the tests myself and found the outdated readme, which is why I went and submitted this PR :) Maybe @alan-agius4 knows 🙂 @alan-agius4 I'm gonna fix this PR in the coming days |
|
You can use the standard jasmine methods |
|
@alan-agius4 Might be worth adding to the README, but Bazel will still download and compile everything no? |
|
Closing as this should be already fixed on master. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The current README is out of date as it still refers to running tests with node. Instead the
package.jsonscripts have been modified to use Bazel instead.