Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create monoalphabetic cipher #3449

Merged
merged 13 commits into from Oct 17, 2020
Merged

create monoalphabetic cipher #3449

merged 13 commits into from Oct 17, 2020
+59 −0

Conversation

@radadiyamohit81
Copy link
Contributor

@radadiyamohit81 radadiyamohit81 commented Oct 17, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@radadiyamohit81
create monoalphabetic cipher
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d24a54d
@radadiyamohit81
update file
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
949790a
@radadiyamohit81
update file
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ac84953
@radadiyamohit81
update file
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7d41624
@radadiyamohit81
update file
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5019b82
@radadiyamohit81 radadiyamohit81 mentioned this pull request Oct 17, 2020
Merged
9 of 14 tasks complete
@cclauss
cclauss reviewed Oct 17, 2020
View changes
ciphers/mono_alphabetic_ciphers.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Oct 17, 2020
View changes
ciphers/mono_alphabetic_ciphers.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Oct 17, 2020
View changes
ciphers/mono_alphabetic_ciphers.py Outdated Show resolved Hide resolved
@radadiyamohit81
update file
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4ff85e5
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 17, 2020

Travis tests have failed

Hey @radadiyamohit81,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2023a820-1083-11eb-af89-615b230ba186
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 17, 2020 •
edited

Can you please do python3 -m pip install flake8 on your local computer and then.

flake8 mono_alphabetic_ciphers.py
@radadiyamohit81
Copy link
Contributor Author

@radadiyamohit81 radadiyamohit81 commented Oct 17, 2020

let me try it
@radadiyamohit81
update after testing flake8 on this code
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8429a56
@radadiyamohit81
update file
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b01883e
@radadiyamohit81
Copy link
Contributor Author

@radadiyamohit81 radadiyamohit81 commented Oct 17, 2020

Thank you @cclauss, I learned new things from this Thank you so much
@cclauss
cclauss reviewed Oct 17, 2020
View changes
ciphers/mono_alphabetic_ciphers.py Outdated Show resolved Hide resolved
@radadiyamohit81
update file
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e038ac4
@radadiyamohit81
update file
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0aba1d0
@cclauss
cclauss reviewed Oct 17, 2020
View changes
ciphers/mono_alphabetic_ciphers.py Outdated Show resolved Hide resolved
@radadiyamohit81
update file
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
63a3e41
@cclauss
cclauss reviewed Oct 17, 2020
View changes
ciphers/mono_alphabetic_ciphers.py Outdated Show resolved Hide resolved
@radadiyamohit81
update file
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a95f5a4
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 17, 2020

One last change needed...
charsA, charsB, symIndex, myMessage, myKey, myMode -->
chars_a, chars_b, sym_index, message, key, mode
@radadiyamohit81
update file
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ee5ce52
@cclauss
cclauss approved these changes Oct 17, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment

Cool... I would have simplified with from string import ascii_letters but this way works too.
@cclauss cclauss merged commit 2ec3750 into TheAlgorithms:master Oct 17, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@radadiyamohit81
Copy link
Contributor Author

@radadiyamohit81 radadiyamohit81 commented Oct 17, 2020

Ya its works too and Thank you so much
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@radadiyamohit81 @TravisBuddy @cclauss
You can’t perform that action at this time.