Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints for searches/ternary_search.py #2874

Merged
merged 1 commit into from Oct 5, 2020
Merged

Add type hints for searches/ternary_search.py #2874

merged 1 commit into from Oct 5, 2020

Conversation

@DmytroLitvinov
Copy link
Contributor

@DmytroLitvinov DmytroLitvinov commented Oct 5, 2020

Describe your change:

This PR adds type hints according to issue #2128.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@DmytroLitvinov
Add type hints for searches/ternary_search.py
Verified
This commit was signed with a verified signature.
DmytroLitvinov Dmytro Litvinov
GPG key ID: 805E7168ADCA1743 Learn about signing commits
Loading status checks…
95e03d4
@DmytroLitvinov
Copy link
Contributor Author

@DmytroLitvinov DmytroLitvinov commented Oct 5, 2020

Friendly ping @dhruvmanila for checking.
@dhruvmanila
dhruvmanila approved these changes Oct 5, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Looks good. Thanks for doing this! 😁
@dhruvmanila dhruvmanila merged commit 7df91e6 into TheAlgorithms:master Oct 5, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@DmytroLitvinov @dhruvmanila
You can’t perform that action at this time.