Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typehints to blockchain #3149

Open
wants to merge 6 commits into
base: master
from
Open

Add typehints to blockchain #3149

wants to merge 6 commits into from
+14 −14

Conversation

@jenia90
Copy link
Contributor

@jenia90 jenia90 commented Oct 10, 2020 •
edited

#2510 and #2128 Added type hints to the blockchain algorithms functions.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
github-actions and others added 4 commits Oct 9, 2020
github-actions github-actions
updating DIRECTORY.md
5017aa2
@jenia90
Merge remote-tracking branch 'origin/master'
0c02224
github-actions github-actions
updating DIRECTORY.md
1144496
@jenia90
Added type hints to blockchain algorithms
Loading status checks…
44fafd9
@jenia90 jenia90 changed the title #2128 Add typehints to blockchain Add typehints to blockchain Oct 15, 2020
jenia90 and others added 2 commits Oct 15, 2020
@jenia90
Merge branch 'master' into jenia90/2510_add_typehints_to_blockchain
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8c177aa
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
11cb774
@jenia90
Copy link
Contributor Author

@jenia90 jenia90 commented Oct 18, 2020

@poyea hey, I'm not sure I should address you here, but can you or someone else review and tag this PR for hacktoberfest? Thanks a lot in advance! :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@jenia90
You can’t perform that action at this time.