Fix codebgcolor and codetextcolor for Sphinx 3.1.0+ #57

zmwangx · 2020-10-10T03:15:48Z

Sphinx 3.1.0+ dropped the custom codebgcolor and codetextcolor from the classic theme (see commit sphinx-doc/sphinx@b345acc), leaving pre elements uncolored.

Without the fix:

Should be:

Sphinx 3.1.0+ dropped the custom codebgcolor and codetextcolor from the classic theme[1], leaving pre elements uncolored. [1] sphinx-doc/sphinx@b345acc

See python/python-docs-theme#57. Also blacken.

zmwangx · 2020-10-10T13:47:45Z

Wait, was this change intentional? Just noticed that Python 3.10 docs, rendered with Sphinx 3.2.1, features background color-less code blocks.

In any case I certainly prefer the old style.

JulienPalard · 2020-10-10T14:29:36Z

Looks related to sphinx-doc/sphinx#7720 / sphinx-doc/sphinx#7721

zmwangx · 2020-10-10T14:33:46Z

Yeah, sphinx-doc/sphinx#7720 led to sphinx-doc/sphinx#7721 led to sphinx-doc/sphinx@b345acc.

corona10 · 2020-10-17T15:08:14Z

https://bugs.python.org/issue42042

the-knights-who-say-ni added the CLA signed label Oct 10, 2020

python / python-docs-theme

Fix codebgcolor and codetextcolor for Sphinx 3.1.0+ #57

Fix codebgcolor and codetextcolor for Sphinx 3.1.0+ #57

zmwangx commented Oct 10, 2020

zmwangx commented Oct 10, 2020

JulienPalard commented Oct 10, 2020 •

edited

zmwangx commented Oct 10, 2020

corona10 commented Oct 17, 2020

python / python-docs-theme

Join GitHub today

Fix codebgcolor and codetextcolor for Sphinx 3.1.0+ #57

Fix codebgcolor and codetextcolor for Sphinx 3.1.0+ #57

Conversation

zmwangx commented Oct 10, 2020

zmwangx commented Oct 10, 2020

JulienPalard commented Oct 10, 2020 • edited

zmwangx commented Oct 10, 2020

corona10 commented Oct 17, 2020

Essential cookies

Always active

Analytics cookies

JulienPalard commented Oct 10, 2020 •

edited