Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve favicons to match www.python.org #56

Open
wants to merge 3 commits into
base: master
from

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 16, 2020

The Python favicons on https://docs.python.org (and https://pip.pypa.io etc.) are much lower than on https://www.python.org

Here they are, docs on the left, www on the right, on a Mac Retina screen:

image


The first commit here (5088726) adds favicon.ico from https://github.com/python/pythondotorg/tree/master/static/favicon.ico (containing 16x16, 32x32 and icons) and uses it for the basic favicon instead of the low-resolution 16x16px py.pny.


The second (1b2f0e0) add the Apple touch icons and Microsoft Win8 tile icons, also from https://github.com/python/pythondotorg/tree/master/static, and shows them with the same markup as www.python.org:

https://github.com/python/pythondotorg/blob/65cb6aa6e9f2e2f87195e1997cfe74d32701c0be/templates/base.html#L41-L52


Finally, the third (471c170) copies the 57x57px apple-touch-icon-precomposed.png (the smallest new one) on top of the low-res 16x16px py.png which is shown inline in the header/footer breadcrumbs, and shows it also at 16x16px.

(So apple-touch-icon-precomposed.png and py.png are duplicates. Would it better to use a single filename for both? If so, what?)


Before

image

After

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.