Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmake sidebar sticky #20
Comments
|
Hi @v-python, sorry you had a not-so-friendly experience reporting this! In terms of stickying the sidebar, it's problematic because many time it prevents navbars with lots of items from being completely visible or users with smaller screens from seeing the entirety of the sidebar. Do we have any solutions to that? |
|
Sidebar content can be in independently scrollable container, with no constraints on height, limited to window height. If the window height is big enough for the sidebar content, no scrollbar appears. If the sidebar content exceeds the window height, you get an extra scrollbar for it. |
|
And that would allow you to scroll the sidebar content while still seeing the main content where you were, which might be helping to give you context for what you want to look for in the sidebar. And another annoyance I've had... you scroll to top to search the sidebar, but lose the context of where you were, if you don't find what you were looking for in the sidebar, and want to return to where you were in the main content, but you had to scroll away to find the sidebar. |
|
i reported this as a bug in 2018-05-07 https://bugs.python.org/issue33442. Do you need help resolving it ? I feel it should be easy to replicate and resolve as the python 2.7 documentation theme works fine. |
Yes, this is a volunteer project. We're happy to review pull requests. |
|
I'm also still skeptical of this change being "the best thing to do". @Mariatta, what are your thoughts? |
|
Mariatta was mentioned, but she's out of open source for the rest of September 2018. Be aware she might not get to this until October 2018. |
|
There's a patch in an issue on b.p.o here https://bugs.python.org/issue24712 that looks to work for 2.7. But nothing works in 3. We definitively need help here, front-end is not my thing þ |
|
There's an almost duplicate of this issue on b.p.o : https://bugs.python.org/issue32393, I mean if we make the menu sticky, let's not make it jitter. |
|
We merged the patch from https://bugs.python.org/issue24712 to the 2.7 branch it should no longer flicker. Still have to fix Python 3 version (I don't know how to do it). |
All the relevant comments are over there https://bugs.python.org/issue28044 which got closed as soon as I added my comment, which isn't a particularly friendly sequence of events. If the issues there are outdated, they should be marked outdated and transferred here as part of the transition.
My comment is that the sidebar menus scroll off the top when you scroll down the page, so they are pretty useless, instead of helpful.
Nice implementation of sticky sidebar.
https://css-tricks.com/sticky-smooth-active-nav/#more-273952
I haven't looked at the patch, and don't know what R. David Murray doesn't like about how it works, but I find the Python sidebar extremely annoying because it scrolls off the top, and would rather it stayed around visible.