Skip to content

/ python-docs-theme

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme #43

Open
vitaly-zdanevich opened this issue Feb 1, 2020 · 7 comments
Open

Dark theme #43

vitaly-zdanevich opened this issue Feb 1, 2020 · 7 comments

Comments

@vitaly-zdanevich
Copy link

@vitaly-zdanevich vitaly-zdanevich commented Feb 1, 2020

Please save our eyes. And batteries. Do not ignore this property of useragent https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

Cross-defect with https://bugs.python.org/issue39518
@opensource-assist
Copy link

@opensource-assist opensource-assist commented Feb 3, 2020

@vitaly-zdanevich
How about this?
@vitaly-zdanevich
Copy link
Author

@vitaly-zdanevich vitaly-zdanevich commented Feb 4, 2020

I know about such extensions, but this is only for desktop browser. Youtube has dark theme, Google Calendar has dark theme on mobile - this is basic feature, dark theme is not for beauty - dark theme is against pain in eyes.

You need to add maybe 10 lines of CSS. I can do it if you approve me.
@opensource-assist
Copy link

@opensource-assist opensource-assist commented Feb 4, 2020 •
edited

@vitaly-zdanevich

I know about such extensions, but this is only for desktop browser. Youtube has dark theme, Google Calendar has dark theme on mobile - this is basic feature, dark theme is not for beauty - dark theme is against pain in eyes.

You need to add maybe 10 lines of CSS. I can do it if you approve me.

Why don't you do the PR on CPython's repo? The docs are served in there.
@vitaly-zdanevich
Copy link
Author

@vitaly-zdanevich vitaly-zdanevich commented Feb 4, 2020

But theme is in this repository.
@septatrix
Copy link

@septatrix septatrix commented Feb 5, 2020

If you don't mind I'd like to work on this issue and make a pull request with some design drafts...
@vitaly-zdanevich
Copy link
Author

@vitaly-zdanevich vitaly-zdanevich commented Feb 5, 2020

Ok.
@septatrix septatrix mentioned this issue Feb 5, 2020
Open
8 of 10 tasks complete
@septatrix
Copy link

@septatrix septatrix commented Feb 5, 2020

Just pushed a first draft if you want to take a look (#44)...
@hugovk hugovk mentioned this issue Oct 3, 2020
Closed
@hugovk hugovk mentioned this issue Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@vitaly-zdanevich @septatrix @opensource-assist
You can’t perform that action at this time.