Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport 3.8 with tests fix #263
Closed
Conversation
|
Thanks |
|
Done Build status: https://travis-ci.org/github/uburuntu/python-fire |
|
Now with pytype Build status: https://travis-ci.org/github/uburuntu/python-fire |
|
This is going to show us how fast the project is going to adapt. Based on #139 which is almost two years old, I would say that a lot. I am keeping an eye on Fire but I will avoid it for the moment on my own projects. |
|
Merged in 457b156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi!
I want to use Fire in project with Python 3.8, so I think library should be officially supported for 3.8.
I added travis run for 3.8 and one test
testInitRequiresFlagSyntaxSubclassNamedTuplegot failed: link.Investigation showed that now namedtuple attributes of type
collections._tuplegettersince 3.8, notproperty: link, commit:So I added backward compatibility check in
MemberVisiblefunction.One not solved trouble: pytype does not support 3.8 (google/pytype#587) -- https://travis-ci.org/github/uburuntu/python-fire, but I can add check in
travis.ymlto skip it currently.