Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspaceFolder is not supported yet #578

Merged
merged 5 commits into from Nov 5, 2020
Merged

workspaceFolder is not supported yet #578

merged 5 commits into from Nov 5, 2020

Conversation

mtsmfm
Copy link
Contributor

@mtsmfm mtsmfm commented Oct 16, 2020

@welcome
Copy link

@welcome welcome bot commented Oct 16, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added this to Triage in Docs open source board Oct 16, 2020
@janiceilene janiceilene moved this from Triage to Core in Docs open source board Oct 16, 2020
@janiceilene janiceilene added content core labels Oct 16, 2020
@janiceilene
Copy link
Collaborator

@janiceilene janiceilene commented Oct 16, 2020

@mtsmfm Thank you so much for opening a PR! I'll get this triaged for review

@jkeech jkeech requested a review from matthewisabel Oct 16, 2020
@jkeech
Copy link
Contributor

@jkeech jkeech commented Oct 16, 2020

@matthewisabel, there are several properties in this list that are not supported in Codespaces:

Not yet supported

  • workspaceMount
  • workspaceFolder

Not applicable for Codespaces (no plan to support)

  • devPort
  • updateRemoteUserUID
  • shutdownAction

VS Code's devcontainer documentation is closer to being correct -- there are some comments about which properties are not supported in Codespaces or if they behave slightly differently in Codespaces: https://code.visualstudio.com/docs/remote/devcontainerjson-reference

cc @Chuxel

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 24, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale label Oct 24, 2020
@mtsmfm
Copy link
Contributor Author

@mtsmfm mtsmfm commented Oct 25, 2020

@janiceilene @jkeech I've updated the doc to follow the comment

#578 (comment)

@github-actions github-actions bot removed the stale label Oct 25, 2020
@janiceilene janiceilene added the hacktoberfest-accepted label Oct 27, 2020
Copy link
Member

@lecoursen lecoursen left a comment

Thanks so much for letting us know about these unsupported keys! I added a few suggested changes for the best way to convey that information. After you commit those suggestions, I can approve and merge! 😎 🎉

mtsmfm and others added 2 commits Nov 4, 2020
…odespaces-for-your-project.md

Co-authored-by: Laura Coursen <lecoursen@github.com>
…odespaces-for-your-project.md

Co-authored-by: Laura Coursen <lecoursen@github.com>
@mtsmfm
Copy link
Contributor Author

@mtsmfm mtsmfm commented Nov 4, 2020

@lecoursen Applied your suggestions

@lecoursen lecoursen merged commit b1dc16d into github:main Nov 5, 2020
13 checks passed
Docs open source board automation moved this from Core to Done Nov 5, 2020
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 5, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content core hacktoberfest-accepted
Development

Successfully merging this pull request may close these issues.

None yet

5 participants