Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String to StringBuilder in Others/PasswordGen.java #1470

Merged
merged 2 commits into from Sep 18, 2020
Merged

String to StringBuilder in Others/PasswordGen.java #1470

merged 2 commits into from Sep 18, 2020

Conversation

@arrnavvv
Copy link
Contributor

@arrnavvv arrnavvv commented Sep 18, 2020

Describe your change:

Used StringBuilder for the variable password instead of String as it was being modified with every iteration.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
arrnavvv added 2 commits Sep 17, 2020
@arrnavvv
Update README.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
0646f5e
@arrnavvv
Update PasswordGen.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
ebdf7be
@shellhub
shellhub approved these changes Sep 18, 2020
View changes
Copy link
Member

@shellhub shellhub left a comment

LGTM
@shellhub shellhub merged commit 88ac7cf into TheAlgorithms:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellhub shellhub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@arrnavvv @shellhub
You can’t perform that action at this time.