Skip to content
Permalink
master

Commits on Oct 24, 2020

  1. bpo-41052: Fix pickling heap types implemented in C with protocols 0 …

    …and 1 (GH-22870)
    serhiy-storchaka committed Oct 24, 2020
  2. bpo-35823: subprocess: Fix handling of pthread_sigmask() errors (GH-2…

    …2944)
    
    Using POSIX_CALL() is incorrect since pthread_sigmask() returns
    the error number instead of setting errno.
    
    Also handle failure of the first call to pthread_sigmask()
    in the parent process, and explain why we don't handle failure
    of the second call in a comment.
    izbyshev committed Oct 24, 2020
  3. [doc] Fix link to abc.ABCMeta.register in Glossary (GH-22932)

    andresdelfino committed Oct 24, 2020
  4. bpo-42139: Update What's New 3.9 for master (#22936)

    terryjreedy committed Oct 24, 2020
  5. Mention in "What's New" that the import system is starting to be clea…

    …ned up (GH-22931)
    
    Automerge-Triggered-By: GH:brettcannon
    brettcannon committed Oct 24, 2020
  6. bpo-35823: subprocess: Use vfork() instead of fork() on Linux when sa…

    …fe (GH-11671)
    
    * bpo-35823: subprocess: Use vfork() instead of fork() on Linux when safe
    
    When used to run a new executable image, fork() is not a good choice
    for process creation, especially if the parent has a large working set:
    fork() needs to copy page tables, which is slow, and may fail on systems
    where overcommit is disabled, despite that the child is not going to
    touch most of its address space.
    
    Currently, subprocess is capable of using posix_spawn() instead, which
    normally provides much better performance. However, posix_spawn() does not
    support many of child setup operations exposed by subprocess.Popen().
    Most notably, it's not possible to express `close_fds=True`, which
    happens to be the default, via posix_spawn(). As a result, most users
    can't benefit from faster process creation, at least not without
    changing their code.
    
    However, Linux provides vfork() system call, which creates a new process
    without copying the address space of the parent, and which is actually
    used by C libraries to efficiently implement posix_spawn(). Due to sharing
    of the address space and even the stack with the parent, extreme care
    is required to use vfork(). At least the following restrictions must hold:
    
    * No signal handlers must execute in the child process. Otherwise, they
      might clobber memory shared with the parent, potentially confusing it.
    
    * Any library function called after vfork() in the child must be
      async-signal-safe (as for fork()), but it must also not interact with any
      library state in a way that might break due to address space sharing
      and/or lack of any preparations performed by libraries on normal fork().
      POSIX.1 permits to call only execve() and _exit(), and later revisions
      remove vfork() specification entirely. In practice, however, almost all
      operations needed by subprocess.Popen() can be safely implemented on
      Linux.
    
    * Due to sharing of the stack with the parent, the child must be careful
      not to clobber local variables that are alive across vfork() call.
      Compilers are normally aware of this and take extra care with vfork()
      (and setjmp(), which has a similar problem).
    
    * In case the parent is privileged, special attention must be paid to vfork()
      use, because sharing an address space across different privilege domains
      is insecure[1].
    
    This patch adds support for using vfork() instead of fork() on Linux
    when it's possible to do safely given the above. In particular:
    
    * vfork() is not used if credential switch is requested. The reverse case
      (simple subprocess.Popen() but another application thread switches
      credentials concurrently) is not possible for pure-Python apps because
      subprocess.Popen() and functions like os.setuid() are mutually excluded
      via GIL. We might also consider to add a way to opt-out of vfork() (and
      posix_spawn() on platforms where it might be implemented via vfork()) in
      a future PR.
    
    * vfork() is not used if `preexec_fn != None`.
    
    With this change, subprocess will still use posix_spawn() if possible, but
    will fallback to vfork() on Linux in most cases, and, failing that,
    to fork().
    
    [1] https://ewontfix.com/7
    
    Co-authored-by: Gregory P. Smith [Google LLC] <gps@google.com>
    izbyshev and gpshead committed Oct 24, 2020

Commits on Oct 23, 2020

  1. bpo-38976: Add support for HTTP Only flag in MozillaCookieJar (#17471)

    Add support for HTTP Only flag in MozillaCookieJar
    
    Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
    jacobneiltaylor and blurb-it committed Oct 23, 2020
  2. build(deps): bump actions/upload-artifact from v1 to v2.2.0 (GH-22920)

    Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from v1 to v2.2.0.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
    <blockquote>
    <h2>v2.2.0</h2>
    <ul>
    <li>Support for artifact retention</li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/actions/upload-artifact/commit/27bce4eee761b5bc643f46a8dfb41b430c8d05f6"><code>27bce4e</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/112">#112</a> from thboop/main</li>
    <li><a href="https://github.com/actions/upload-artifact/commit/f8b42f7ab442a66b3d51a5ca02855b194a36ae2d"><code>f8b42f7</code></a> update licensed files</li>
    <li><a href="https://github.com/actions/upload-artifact/commit/2106e8cf10e032ca9d5724c4c676543febe74f0b"><code>2106e8c</code></a> update contributing.md</li>
    <li><a href="https://github.com/actions/upload-artifact/commit/db66798ebcfbaa7f3f8ff66bce013213265c30d1"><code>db66798</code></a> Ignore Generated Files in Git PR's</li>
    <li><a href="https://github.com/actions/upload-artifact/commit/d359fd0772ed6802a84728dd6b09ec99f41a67b7"><code>d359fd0</code></a> Manual Verification of licenses</li>
    <li><a href="https://github.com/actions/upload-artifact/commit/350822c32f871c559dbe1667c24424e06c4f03e3"><code>350822c</code></a> Add Licensed Workflow and config</li>
    <li><a href="https://github.com/actions/upload-artifact/commit/abecf4abf4b70bc636949d61150be883b87416c2"><code>abecf4a</code></a> Updated README.md (<a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/118">#118</a>)</li>
    <li><a href="https://github.com/actions/upload-artifact/commit/604e071d21906545dedcfaf210deae74f8c5276a"><code>604e071</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/actions/upload-artifact/issues/126">#126</a> from yacaovsnc/main</li>
    <li><a href="https://github.com/actions/upload-artifact/commit/4560c23b396d494f0cb7066e1d6e258e8feb8051"><code>4560c23</code></a> Check for invalid retention-days input</li>
    <li><a href="https://github.com/actions/upload-artifact/commit/59018c2f85dd0e101b75544aa87f13bb0c94e0b7"><code>59018c2</code></a> Add an option to specify retention period</li>
    <li>Additional commits viewable in <a href="https://github.com/actions/upload-artifact/compare/v1...27bce4eee761b5bc643f46a8dfb41b430c8d05f6">compare view</a></li>
    </ul>
    </details>
    <br />
    
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    
    </details>
    
    Automerge-Triggered-By: GH:Mariatta
    dependabot committed Oct 23, 2020
  3. build(deps): bump actions/cache from v1 to v2.1.2 (GH-22919)

    Bumps [actions/cache](https://github.com/actions/cache) from v1 to v2.1.2.
    <details>
    <summary>Release notes</summary>
    <p><em>Sourced from <a href="https://github.com/actions/cache/releases">actions/cache's releases</a>.</em></p>
    <blockquote>
    <h2>v2.1.2</h2>
    <ul>
    <li>Adds input to limit the chunk upload size, useful for self-hosted runners with slower upload speeds</li>
    <li>No-op when executing on GHES</li>
    </ul>
    </blockquote>
    </details>
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a href="https://github.com/actions/cache/commit/d1255ad9362389eac595a9ae406b8e8cb3331f16"><code>d1255ad</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/actions/cache/issues/424">#424</a> from actions/dhadka/upload-chunk-size</li>
    <li><a href="https://github.com/actions/cache/commit/68cfb2ccb73b1982be3fa55e3d7c842697d7f1ed"><code>68cfb2c</code></a> Add units to description</li>
    <li><a href="https://github.com/actions/cache/commit/cce3c03a74623545a53c433d301f3f7725c72454"><code>cce3c03</code></a> Add new input to action.yml</li>
    <li><a href="https://github.com/actions/cache/commit/4bceb75b5b7743784c63c94b81c50a485cbdcda0"><code>4bceb75</code></a> Use parseInt instead of Number to handle empty strings</li>
    <li><a href="https://github.com/actions/cache/commit/a6f1f4b32eec85780fedc5b354a583e9b2999100"><code>a6f1f4b</code></a> Adds input for upload chunk size</li>
    <li><a href="https://github.com/actions/cache/commit/d606e039ae32f64a8593bf4a37b0bf205c695237"><code>d606e03</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/actions/cache/issues/421">#421</a> from actions/dhadka/ghes</li>
    <li><a href="https://github.com/actions/cache/commit/d3e4f218f30bd71a2c29e2b2a1e4f811f4327162"><code>d3e4f21</code></a> Use warning instead of info</li>
    <li><a href="https://github.com/actions/cache/commit/55a58944386e69f7c5bad52ef43a61c578b6c1c6"><code>55a5894</code></a> Update dist</li>
    <li><a href="https://github.com/actions/cache/commit/3f6dfcbcc44a8e2fd9e539c1dd15af6559e74ced"><code>3f6dfcb</code></a> Merge branch 'main' of <a href="http://github.com/actions/cache">http://github.com/actions/cache</a> into dhadka/ghes</li>
    <li><a href="https://github.com/actions/cache/commit/0f71d4ac9a7f4c36aba5ac3cfc4567d2d4eae813"><code>0f71d4a</code></a> Add tests for isGhes</li>
    <li>Additional commits viewable in <a href="https://github.com/actions/cache/compare/v1...d1255ad9362389eac595a9ae406b8e8cb3331f16">compare view</a></li>
    </ul>
    </details>
    <br />
    
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    
    </details>
    
    Automerge-Triggered-By: GH:Mariatta
    dependabot committed Oct 23, 2020
  4. Allow dependabot to check GitHub actions monthly (GH-22787)

    Let Dependabot update GitHub Actions dependency once a month.
    
    Here's reference to the dependabot configs.
    
    https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/keeping-your-actions-up-to-date-with-github-dependabot
    jlosito committed Oct 23, 2020
  5. Add GitHub sponsor info for Python (GH-22887)

    Sponsor Python on GitHub
    Mariatta committed Oct 23, 2020
  6. Add Mark Shannon to CODEOWNERS. (#22914)

    markshannon committed Oct 23, 2020
  7. bpo-40592: shutil.which will not return None anymore if ; is the last…

    … char in PATHEXT (GH-20088)
    
    shutil.which will not return None anymore for empty str in PATHEXT
    Empty PATHEXT will now be defaulted to _WIN_DEFAULT_PATHEXT
    peanutlord committed Oct 23, 2020
  8. bpo-36876: Fix the C analyzer tool. (GH-22841)

    The original tool wasn't working right and it was simpler to create a new one, partially re-using some of the old code. At this point the tool runs properly on the master. (Try: ./python Tools/c-analyzer/c-analyzer.py analyze.)  It take ~40 seconds on my machine to analyze the full CPython code base.
    
    Note that we'll need to iron out some OS-specific stuff (e.g. preprocessor). We're okay though since this tool isn't used yet in our workflow. We will also need to verify the analysis results in detail before activating the check in CI, though I'm pretty sure it's close.
    
    https://bugs.python.org/issue36876
    ericsnowcurrently committed Oct 23, 2020

Commits on Oct 22, 2020

  1. bpo-38486: Fix dead qmail links in the mailbox docs (GH-22239)

    ZackerySpytz committed Oct 22, 2020
  2. Add CODEOWNERS for the Grammar file (GH-22898)

    lysnikolaou committed Oct 22, 2020
  3. bpo-38980: Only apply -fno-semantic-interposition if available (GH-22892

    )
    encukou committed Oct 22, 2020
  4. bpo-42086: Document AST operator nodes acts as a singleton (GH-22896)

    Automerge-Triggered-By: GH:gvanrossum
    isidentical committed Oct 22, 2020
  5. bpo-42057: Add regression test to master. (GH-22893)

    markshannon committed Oct 22, 2020
  6. bpo-25655: Improve Win DLL loading failures doc (GH-22372)

    Add documentation to help diagnose CDLL dependent DLL loading errors
    on windows for OSError with message:
    "[WinError 126] The specified module could not be found"
    This error is otherwise difficult to diagnose.
    pombredanne committed Oct 22, 2020
  7. Remove 3.5 from Doc version switcher in master. (#22886)

    larryhastings committed Oct 22, 2020
  8. bpo-1635741: Fix NULL ptr deref in multiprocessing (GH-22880)

    Commit 1d541c2 introduced a NULL
    pointer dereference in error path.
    
    Signed-off-by: Christian Heimes <christian@python.org>
    tiran committed Oct 22, 2020
  9. _testmultiphase: Fix possible ref leak (GH-22881)

    This is just test code, but sometimes external contributors reference the code snippets from test code.
    `PyModule_AddObject` should be handled in the proper way.
    
    https://docs.python.org/3/c-api/module.html#c.PyModule_AddObject
    corona10 committed Oct 22, 2020

Commits on Oct 21, 2020

  1. bpo-41910: specify the default implementations of object.__eq__ and o…

    …bject.__ne__ (GH-22874)
    
    See Objects/typeobject.c:object_richcompare() for the implementation of this in CPython.
    
    Automerge-Triggered-By: GH:brettcannon
    brettcannon committed Oct 21, 2020
  2. bpo-38980: Add -fno-semantic-interposition when building with optimiz…

    …ations (GH-22862)
    pablogsal committed Oct 21, 2020
  3. bpo-35181: Correct importlib documentation for some module attributes (

    …GH-15190)
    
    @ericsnowcurrently This PR will change the following:
    
    In the library documentation importlib.rst:
    
    - `module.__package__` can be `module.__name__` for packages;
    - `spec.parent` can be `spec.__name__` for packages;
    - `spec.loader` is not `None` for namespaces packages.
    
    In the language documentation import.rst:
    
    - `spec.loader` is not `None` for namespace packages.
    
    Automerge-Triggered-By: GH:warsaw
    maggyero committed Oct 21, 2020
  4. Fix bpo-39416: Change "Numeric" to lower case; an english word, not a…

    … class name (GH-22867)
    
    This is a trivial fix to [bpo-39416](), which didn't come up until it was already committed
    
    ```
    Change "Numeric" to "numeric".
    
    I believe this is trivial enough to not need an issue or a NEWS entry, although
    I'm unclear on what branches the original pull request received backports.
    ```
    
    Automerge-Triggered-By: GH:merwok
    kpinc committed Oct 21, 2020
  5. bpo-41959: Fix grammar around class asyncio.MultiLoopChildWatcher text (

    GH-22580)
    
    While translating the following document to Spanish we found there is a grammar issue on the original documentation.
    raulcd committed Oct 21, 2020
  6. bpo-39416: Document some restrictions on the default string represent…

    …ations of numeric classes (GH-18111)
    
    [bpo-39416](): Document string representations of the Numeric classes
    
    This is a change to the specification of the Python language.
    
    The idea here is to put sane minimal limits on the Python language's default
    representations of its Numeric classes.  That way "Marty's Robotic Massage Parlor
    and Python Interpreter" implementation of Python won't do anything too
    crazy.
    
    Some discussion in the email thread:
    Subject: Documenting Python's float.__str__()
    https://mail.python.org/archives/list/python-dev@python.org/thread/FV22TKT3S2Q3P7PNN6MCXI6IX3HRRNAL/
    kpinc committed Oct 21, 2020
Older
You can’t perform that action at this time.