Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clang-format): increase ColumnLimit to 100 #3682

Merged
merged 1 commit into from Oct 28, 2016
Merged

chore(clang-format): increase ColumnLimit to 100 #3682

merged 1 commit into from Oct 28, 2016

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented Oct 28, 2016

Does anybody use an 80x25 hardware text-mode terminal to edit this code? Why is this value so low? It doesn't help the readability at all.

The Angular 2 project has ColumnLimit: 100.

Does anybody use an 80x25 hardware text-mode terminal to edit this code? Why is this value so low? It doesn't help the readability at all.

The Angular 2 project has [has](https://github.com/angular/angular/blob/master/.clang-format) `ColumnLimit: 100`.
@cnishina
Copy link
Member

@cnishina cnishina commented Oct 28, 2016

It looks like our Circle CI is having issues. LGTM.

@cnishina cnishina merged commit 4d2f2e4 into angular:master Oct 28, 2016
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants