Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: webpack 5 support status #18873

Draft
wants to merge 4 commits into
base: master
from

Conversation

@valorkin
Copy link
Contributor

@valorkin valorkin commented Sep 24, 2020

This PR is not meant to be merged, but is able to run unit tests with webpack@5
When all green - we have support for webpack@5 :D

@googlebot googlebot added the cla: yes label Sep 24, 2020
@alan-agius4 alan-agius4 marked this pull request as draft Sep 24, 2020
@valorkin
Copy link
Contributor Author

@valorkin valorkin commented Sep 28, 2020

issues top:

  • lazy modules

  • i18n

  • source maps

  • Compiling RuleSet failed: Properties enforce are unknown (at ruleSet[1].rules[5]: [object Object])

  • watch mode doesn't work, this.watcher.close is not a function 34 errors => 22 errors

  • web workers

  • Dev Server Deploy Url works

  • license extraction works

  • builder browser support warns when IE9 is present in browserslist

  • Builder bundle budgets shows error for large component css when using 'anyComponentStyle' when AOT

  • 320 errors Timeout - Async function did not mostly watch mode related

  • 90 errors looks like case mismatch, but most like now error is logged in another place Error: .../app.component.less exceeded maximum budget. Budget 1 bytes was not met by 82 bytes with a total of 83 bytes. ' to match 'ERROR.+app.component.less'.

  • 8 errors Error: Compiling RuleSet failed: Properties enforce are unknown (at ruleSet[1].rules[5]: [object Object]) (was 72)

  • 580 DeprecationWarnings:

    • 229 #18911 [DEP_WEBPACK_COMPILATION_AFTER_OPTIMIZE_CHUNK_ASSETS] DeprecationWarning: afterOptimizeChunkAssets is deprecated (use Compilation.hook.processAssets instead and use one of Compilation.PROCESS_ASSETS_STAGE_* as stage option)
    • 225 #18913 [DEP_WEBPACK_MODULE_ISSUER] DeprecationWarning: Module.issuer: Use new ModuleGraph API
    • 83 #18914 [DEP_WEBPACK_COMPILATION_OPTIMIZE_CHUNK_ASSETS] DeprecationWarning: optimizeChunkAssets is deprecated (use Compilation.hook.processAssets instead and use one of Compilation.PROCESS_ASSETS_STAGE_* as stage option)
    • 5 [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated. BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation. Do changes to assets earlier, e. g. in Compilation.hooks.processAssets. Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
    • 18 #18925 [DEP_WEBPACK_DEPRECATION_ARRAY_TO_SET_PUSH] DeprecationWarning: chunk.files was changed from Array to Set (using Array method 'push' is deprecated)
    • 20 #18915 [DEP_WEBPACK_MAIN_TEMPLATE_ASSET_PATH] DeprecationWarning: MainTemplate.hooks.assetPath is deprecated (use Compilation.hooks.assetPath instead)

test log:
cli-test-01.log

@valorkin
Copy link
Contributor Author

@valorkin valorkin commented Sep 28, 2020

merged - webpack-source@2 typings in PR already DefinitelyTyped/DefinitelyTyped#47817

@valorkin valorkin mentioned this pull request Sep 28, 2020
2 of 15 tasks complete
@valorkin
Copy link
Contributor Author

@valorkin valorkin commented Sep 28, 2020

    // TODO_WEBPACK_5
    // the proper typing is available only in tapable, but importing of it leads to
    // Module 'tapable' is not listed as dependency in package.json
    // (_compilation.hooks as unknown as { processAssets: AsyncSeriesHook<[Record<string, Source>]>; })
@valorkin valorkin closed this Sep 29, 2020
@valorkin valorkin force-pushed the valorkin:fix-webpack5-types-compat branch from ef2c338 to 38023fe Sep 29, 2020
@valorkin valorkin reopened this Sep 29, 2020
@valorkin valorkin force-pushed the valorkin:fix-webpack5-types-compat branch from 6341d37 to a45f035 Sep 29, 2020
@valorkin
Copy link
Contributor Author

@valorkin valorkin commented Sep 29, 2020

fix 3rd party licences

Running `ng "build" "--prod" "--extract-licenses" "--output-hashing=none"` [silent]...
CWD: /mnt/ramdisk/test-project
ENV: undefined
Last step took 36.33s...

Error: File dist/test-project/3rdpartylicenses.txt was expected to exist but not found...
    at /home/circleci/ng/tests/legacy-cli/e2e/utils/fs.ts:163:24
    at suppressedCallback (fs.js:215:5)
    at FSReqCallback.oncomplete (fs.js:156:23)


Test "tests/build/extract-licenses" failed...
File dist/test-project/3rdpartylicenses.txt was expected to exist but not found...
Error: File dist/test-project/3rdpartylicenses.txt was expected to exist but not found...
    at /home/circleci/ng/tests/legacy-cli/e2e/utils/fs.ts:163:24
    at suppressedCallback (fs.js:215:5)
    at FSReqCallback.oncomplete (fs.js:156:23)```
@valorkin valorkin force-pushed the valorkin:fix-webpack5-types-compat branch 6 times, most recently from 522e94b to e555ed4 Oct 6, 2020
valorkin added 2 commits Oct 6, 2020
@valorkin valorkin force-pushed the valorkin:fix-webpack5-types-compat branch from e555ed4 to 733ae1d Oct 19, 2020
@valorkin valorkin force-pushed the valorkin:fix-webpack5-types-compat branch from d107b70 to 60d2f68 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.