Skip to content

/ angular-cli

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated dependency: request@2.88.2 #16952

Open
petebacondarwin opened this issue Feb 12, 2020 · 16 comments
Open

deprecated dependency: request@2.88.2 #16952

petebacondarwin opened this issue Feb 12, 2020 · 16 comments
Labels
blocked on upstream comp: angular/cli freq3: high severity2: inconvenient triage #1 type: bug/fix
Milestone
Backlog

Comments

@petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented Feb 12, 2020

It appears that this version, which is deprecated is being pulled in by @angular/cli (via universal-analytics). I assume a bump to the latter's version will be enough to fix this?

You can see this warning when doing a fresh install of CLI@9.0.1:

warning @angular/cli > universal-analytics > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
@wartab
Copy link

@wartab wartab commented Feb 12, 2020

The paackage request is now fully deprecated. So that will probably take a while to change.
@petebacondarwin
Copy link
Member Author

@petebacondarwin petebacondarwin commented Feb 12, 2020

Yes, I think the solution would be for universal-analytics to release a new version that is not reliant upon request.
@ngbot ngbot bot added this to the needsTriage milestone Feb 12, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Feb 12, 2020
@AURZeeshan
Copy link

@AURZeeshan AURZeeshan commented Feb 18, 2020

problem ! request@2.88.2..

what are the alternative of it ?
@BruneXX
Copy link

@BruneXX BruneXX commented Mar 16, 2020

Hi, any update on this? thanks!
@khalidsheet
Copy link

@khalidsheet khalidsheet commented Mar 16, 2020

@BruneXX
Me too, I'm waiting for a fix or something
@BruneXX
Copy link

@BruneXX BruneXX commented Mar 17, 2020

I think we'll need to check here: request/request#3142
@smoncadav
Copy link

@smoncadav smoncadav commented Apr 4, 2020

I'm also getting this issue when installing angular CLI

npm install -g @angular/cli
npm WARN deprecated request@2.88.2: request has been deprecated, see request/request#3142
@akhilh2o
Copy link

@akhilh2o akhilh2o commented Apr 14, 2020

I'm also waiting for this solution===>

npm WARN deprecated request@2.88.2: request has been deprecated, see request/request#3142
C:\Users\hp\AppData\Roaming\npm\ng -> C:\Users\hp\AppData\Roaming\npm\node_modules@angular\cli\bin\ng

@angular/cli@9.1.1 postinstall C:\Users\hp\AppData\Roaming\npm\node_modules@angular\cli
node ./bin/postinstall/script.js

? Would you like to share anonymous usage data with the Angular Team at Google under
Google’s Privacy Policy at https://policies.google.com/privacy? For more details and
how to change this setting, see http://angular.io/analytics. No

  • @angular/cli@9.1.1
    added 272 packages from 207 contributors in 341.271s
@Serine18
Copy link

@Serine18 Serine18 commented Apr 21, 2020

i have the same probleme,has any one found a solution

npm WARN deprecated request@2.88.2: request has been deprecated, see request/request#3142
C:\Users\pc pro\AppData\Roaming\npm\ng -> C:\Users\pc pro\AppData\Roaming\npm\node_modules@angular\cli\bin\ng
@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Apr 22, 2020

This is currently blocked as it requires an upstream change.

peaksandpies/universal-analytics#143
@fToledo29
Copy link

@fToledo29 fToledo29 commented Apr 22, 2020

Any updates about this issue?
@Serine18
Copy link

@Serine18 Serine18 commented Apr 22, 2020

@jburson
Copy link

@jburson jburson commented Apr 28, 2020

Looks like their only usage is https://github.com/peaksandpies/universal-analytics/blob/master/lib/index.js#L444
@beeman
Copy link
Contributor

@beeman beeman commented May 6, 2020

I submitted a PR to peaksandpies/universal-analytics but the last commit to that project was 1.5 year ago so I doubt it will land anytime soon. Also, while upgrading said project, I got blocked on one of the unit tests (see PR).
@dgp1130 dgp1130 added the triage #1 label May 28, 2020
@renovate renovate bot mentioned this issue Jul 2, 2020
Merged
0 of 1 task complete
@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jul 2, 2020

Closed via #18113
@alan-agius4 alan-agius4 closed this Jul 2, 2020
@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jul 7, 2020

Reopening since this was reverted in #18173
@alan-agius4 alan-agius4 reopened this Jul 7, 2020
@alan-agius4 alan-agius4 mentioned this issue Sep 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked on upstream comp: angular/cli freq3: high severity2: inconvenient triage #1 type: bug/fix
Projects
None yet
Milestone
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.