Skip to content

Hacktoberfest: Added solution for Project Euler problem 83#3733

Closed
Stefan-Radu wants to merge 3 commits intoTheAlgorithms:masterfrom
Stefan-Radu:stefan-radu/solution-for-project-euler-problem-83
Closed

Hacktoberfest: Added solution for Project Euler problem 83#3733
Stefan-Radu wants to merge 3 commits intoTheAlgorithms:masterfrom
Stefan-Radu:stefan-radu/solution-for-project-euler-problem-83

Conversation

@Stefan-Radu
Copy link

@Stefan-Radu Stefan-Radu commented Oct 25, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Stefan-Radu Stefan-Radu changed the title Solution of Project Euler problem 83 Hacktoberfest: Added Solution of Project Euler problem 83 Oct 25, 2020
@Stefan-Radu Stefan-Radu changed the title Hacktoberfest: Added Solution of Project Euler problem 83 Hacktoberfest: Added solution for Project Euler problem 83 Oct 25, 2020
@ghost
Copy link

ghost commented Oct 25, 2020

This is now ready

@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 26, 2020
@stale
Copy link

stale bot commented Nov 28, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 28, 2020
@ghost
Copy link

ghost commented Nov 29, 2020

ping @Stefan-Radu

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Nov 29, 2020
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 29, 2020
@ghost
Copy link

ghost commented Nov 29, 2020

@dhruvmanila check this out

@dhruvmanila
Copy link
Member

This PR cannot be merged as there a few changes required but the user has deleted the forked repository from where the pull request originated from. Thus, if @Stefan-Radu wants to submit this solution, please open a new pull request for it. Thank you for your cooperation.

@ghost
Copy link

ghost commented Nov 29, 2020

@dhruvmanila shall we close it then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants