Skip to content

Hacktoberfest: Added solution for Project Euler problem 87#3734

Closed
Stefan-Radu wants to merge 2 commits intoTheAlgorithms:masterfrom
Stefan-Radu:stefan-radu/solution-for-project-euler-problem-87
Closed

Hacktoberfest: Added solution for Project Euler problem 87#3734
Stefan-Radu wants to merge 2 commits intoTheAlgorithms:masterfrom
Stefan-Radu:stefan-radu/solution-for-project-euler-problem-87

Conversation

@Stefan-Radu
Copy link

@Stefan-Radu Stefan-Radu commented Oct 25, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Stefan-Radu Stefan-Radu changed the title Added solution for Project Euler problem 87 Hacktoberfest: Added solution for Project Euler problem 87 Oct 25, 2020
@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 26, 2020
@dhruvmanila
Copy link
Member

Thank you for your contribution but we do not accept solution to existing problems.

@dhruvmanila dhruvmanila removed the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 29, 2020
@Stefan-Radu
Copy link
Author

Three PR's of mine were rejected for this reason, without considering the fact that at the moment of making the PR, there were no solutions for those problems. I don't think that's fair, in any way.

@dhruvmanila
Copy link
Member

I'm sorry it came down to that but you also have to consider the fact that we are being flooded with hundreds of pull requests where a lot of them have been invalid. Also, we have mentioned to submit only one PR at a time to make it easy for us to review. I cannot force people to not open multiple PRs.

Another thing is that when you opened the PR, there could have been other PRs opened for the problem. If we are spending this much time in reviewing your PR, you could spare a minute to search the pull request for duplicates. Thank you for your cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants