C#: Fix CFG for assertions with multiple assertion arguments#4568
Merged
hvitved merged 2 commits intogithub:mainfrom Oct 30, 2020
Merged
C#: Fix CFG for assertions with multiple assertion arguments#4568hvitved merged 2 commits intogithub:mainfrom
hvitved merged 2 commits intogithub:mainfrom
Conversation
a20500b to
39e42e3
Compare
39e42e3 to
51f71d4
Compare
tamasvajk
approved these changes
Oct 29, 2020
Contributor
Author
|
CSharp-Changes looks good, so merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #4484.
The control-flow graph for
M13belownow becomes
(Note that the graph visualizer is, for some reason, not able to show both the
trueandfalseedges out of[assertion failure] access to parameter b2(highlighted in red), possibly because the two edges have the same target.)CSharp-Differences job here.