allow plugins to use widgets lib #5377
Open
Conversation
I have plugins that use classes from the nativescript widget libs. Now i want to publish the plugin with the java sources directly. If i do that i need to add `widget-release` to the dependencies. Now i could do that in the plugin include.gradle, it will make plugin build to work however then app building wont work because the widgets lib will be included twice So the best solution is automatically add it here. I am not happy about the path thing, however it will work in all cases.
|
Ok so actually find a way to declare the dependency without needing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I have plugins that use classes from the nativescript widget libs.
Now i want to publish the plugin with the java sources directly.
If i do that i need to add
widget-releaseto the dependencies.Now i could do that in the plugin include.gradle, it will make plugin build to work however then app building wont work because the widgets lib will be included twice
So the best solution is automatically add it here.
I am not happy about the path thing, however it will work in all cases.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].