Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knuth Morris Pratt Algorithm for string Matching #1604

Open
wants to merge 2 commits into
base: master
from
Open

Knuth Morris Pratt Algorithm for string Matching #1604

wants to merge 2 commits into from

Conversation

@Tharun0102
Copy link

@Tharun0102 Tharun0102 commented Oct 4, 2020 •
edited

Describe your change:

Adding an Algorithm.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Tharun0102
Knuth Morris Pratt Algorithm for string Matching
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6a1fa13
@dynamitechetan
dynamitechetan reviewed Oct 5, 2020
View changes
Copy link
Member

@dynamitechetan dynamitechetan left a comment

Thanks for the PR.
Small suggestion please remove the extra white lines and please reformat the code.
@Tharun0102
Update String_Matching_Algo_KMP.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
085968b
@Tharun0102
Copy link
Author

@Tharun0102 Tharun0102 commented Oct 6, 2020

Yeah. I have removed those spaces. Please have a look.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dynamitechetan dynamitechetan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Tharun0102 @dynamitechetan
You can’t perform that action at this time.