Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LongestRepeatingSequence #1724

Open
wants to merge 2 commits into
base: master
from
Open

LongestRepeatingSequence #1724

wants to merge 2 commits into from

Conversation

@Himsahu
Copy link

@Himsahu Himsahu commented Oct 10, 2020

The longest sequence which has been repeated twice

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
The longest sequence which has been repeated twice
public class LongestRepeatingSequence {
//Checks for the largest common prefix
public static String lcp(String s, String t){
int n = Math.min(s.length(),t.length());
for(int i = 0; i < n; i++){
if(s.charAt(i) != t.charAt(i)){
return s.substring(0,i);
}
}
return s.substring(0,n);
}

public static void main(String[] args) {

Scanner sc = new Scanner(System.in);
String str = sc.next();
String lrs="";
int n = str.length();
for(int i = 0; i < n; i++){
for(int j = i+1; j < n; j++){

String x = lcp(str.substring(i,n),str.substring(j,n));
if(x.length() > lrs.length()) lrs=x;
}
}
System.out.println("Longest repeating sequence: "+lrs);
}
}
Comment on lines 1 to 28

This comment has been minimized.

@mertcandav

mertcandav Oct 10, 2020

Hi. Whitespace patterns in the code are unbalanced. Please keep the number of spaces between operators and tokens.

Suggested change
public class LongestRepeatingSequence {
//Checks for the largest common prefix
public static String lcp(String s, String t){
int n = Math.min(s.length(),t.length());
for(int i = 0; i < n; i++){
if(s.charAt(i) != t.charAt(i)){
return s.substring(0,i);
}
}
return s.substring(0,n);
}
public static void main(String[] args) {
Scanner sc = new Scanner(System.in);
String str = sc.next();
String lrs="";
int n = str.length();
for(int i = 0; i < n; i++){
for(int j = i+1; j < n; j++){
String x = lcp(str.substring(i,n),str.substring(j,n));
if(x.length() > lrs.length()) lrs=x;
}
}
System.out.println("Longest repeating sequence: "+lrs);
}
}
public class LongestRepeatingSequence {
//Checks for the largest common prefix
public static String lcp(String s, String t) {
int n = Math.min(s.length(), t.length());
for (int i = 0; i < n; i++) {
if (s.charAt(i) != t.charAt(i)) {
return s.substring(0, i);
}
}
return s.substring(0,n);
}
public static void main(String[] args) {
Scanner sc = new Scanner(System.in);
String str = sc.next();
String lrs = "";
int n = str.length();
for (int i = 0; i < n; i++) {
for (int j = i + 1; j < n; j++) {
String x = lcp(str.substring(i, n), str.substring(j, n));
if (x.length() > lrs.length()) {
lrs = x;
}
}
}
System.out.println("Longest repeating sequence: " + lrs);
}
}

This comment has been minimized.

@Himsahu

Himsahu Oct 10, 2020
Author

Please accept all my pull request, so that I can participate in Hacktoberfest

@mertcandav
Copy link

@mertcandav mertcandav commented Oct 10, 2020

Please add comments for the algorithm to be understood by all.

Copy link

@mertcandav mertcandav left a comment

LGTM 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.