C#: Roslyn 3.8 upgrade + C# 9 test cases#4537
Closed
tamasvajk wants to merge 12 commits intogithub:mainfrom
Closed
C#: Roslyn 3.8 upgrade + C# 9 test cases#4537tamasvajk wants to merge 12 commits intogithub:mainfrom
tamasvajk wants to merge 12 commits intogithub:mainfrom
Conversation
405ba1e to
514c04a
Compare
tamasvajk
commented
Oct 26, 2020
| @@ -0,0 +1,10 @@ | |||
| [VALUE_NOT_IN_TYPE] predicate attributes(@attribute id, @type_or_ref type_id, @attributable target): Value 810 of field target is not in type @attributable. The value is however in type @local_function. Appears in tuple (806,809,810) | |||
| Relevant element: Full ID for 809: @"(808);typeRef". The ID may expand to @"{@"{@"{@";namespace"}.System;namespace"}.ObsoleteAttribute : {@"{@"(38).System;namespace"}.Attribute;type"};type"};typeRef" | |||
| [VALUE_NOT_IN_TYPE] predicate type_nullability(@has_type_annotation id, @nullability nullability): Value 513 of field id is not in type @has_type_annotation. Appears in tuple (513,57) | |||
Contributor
Author
There was a problem hiding this comment.
This is caused by not handling IFunctionPointerTypeSymbol.
23534e7 to
75a3b01
Compare
892dca9 to
441ae86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/github/semmle-code/pull/38050