Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the menu be pinned like it was in 2.7? #8

Open
JulienPalard opened this issue Dec 21, 2017 · 2 comments
Open

Should the menu be pinned like it was in 2.7? #8

JulienPalard opened this issue Dec 21, 2017 · 2 comments

Comments

@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Dec 21, 2017

While working on the doc with @FGuillet and @BrunoMaugery we spotted some javascript updating the position of the menu, like to "pin" it on the screen while scrolling, like 2.7 is still doing. We though it was just broken, but do we want to keep this feature? It looks like it causes jiterring problems in 2.7 https://bugs.python.org/issue32393.

@theacodes
Copy link
Collaborator

@theacodes theacodes commented Jan 2, 2018

i'm not a huge fan of pinning personally.

@septatrix
Copy link

@septatrix septatrix commented Feb 11, 2020

I personally like the pinning as it gives me the possibility to jump to another section even when im halfway through the page.
Following a few redirects in the bug report you linked I was able to find this commit python/cpython@8ab24b2. Apparently this fixes the issue. However this is not yet implemented in this theme but we probably could simply apply this patch here.
Does anyone know why there are apparently two different locations where this theme is maintained anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.