New UnsafeDeserialization sink and improvements to SnakeYaml sink#4603
Merged
aschackmull merged 10 commits intogithub:mainfrom Nov 5, 2020
pwntester:new_deser_sink
Merged
New UnsafeDeserialization sink and improvements to SnakeYaml sink#4603aschackmull merged 10 commits intogithub:mainfrom pwntester:new_deser_sink
aschackmull merged 10 commits intogithub:mainfrom
pwntester:new_deser_sink
Conversation
aschackmull
reviewed
Nov 4, 2020
Contributor
|
Looks good. Could you add a change note stating that the unsafe deserialization query has been improved with the additional sink? Look in |
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
… new_deser_sink
aschackmull
reviewed
Nov 4, 2020
java/change-notes/2020-11-04-commonslang-unsafe-deserialization-sinks.md
Outdated
Show resolved
Hide resolved
…n-sinks.md Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
aschackmull
previously approved these changes
Nov 4, 2020
Contributor
|
aschackmull
reviewed
Nov 4, 2020
| } | ||
| } | ||
|
|
||
| class MethodApacheSerializationUtilsDeserialize extends Method { |
Contributor
There was a problem hiding this comment.
As the error indicates, this class needs qldoc.
aschackmull
reviewed
Nov 5, 2020
| } | ||
|
|
||
| /*--- Methods ---*/ | ||
| /** The method `deserialize` in either `org.apache.commons.lang.SerializationUtils` |
Contributor
There was a problem hiding this comment.
This qldoc is not formatted correctly, and indeed we get:
[ERROR] Input file ql/java/ql/src/semmle/code/java/frameworks/apache/Lang.qll is not correctly formatted
aschackmull
approved these changes
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.