Merged
Conversation
Contributor
Author
| @@ -0,0 +1,3 @@ | |||
| lgtm,codescanning | |||
| * Exported Android `Intent`s have been added as sources of tainted data for all | |||
Contributor
There was a problem hiding this comment.
Maybe be more specific?
Suggested change
| * Exported Android `Intent`s have been added as sources of tainted data for all | |
| * Exported Android `Intent`s have been added as remote sources of tainted data for all |
Contributor
Author
There was a problem hiding this comment.
I know that we have some modelling of local taint sources, but these are not really used in practice - they merely exist to support certain benchmark tests. In practice all sources of tainted data are remote sources, so I'm not sure the distinction is worth pointing out here - I think we'd rather be succinct, but in the end I'll leave that to our documentation team.
yo-h
approved these changes
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3812 just made it into the rc so we'll need a change note for it there as well.