Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42142: Skip select ttk tests when on Ubuntu #23156

Closed
wants to merge 6 commits into from

Conversation

E-Paine
Copy link
Contributor

@E-Paine E-Paine commented Nov 4, 2020

Note: This is only designed as a temporary solution to avoid the inconvenience inevitably caused to other (unrelated) PRs.

Note: This will apply (I believe) for all Ubuntu machines (it will certainly affect Azure Pipelines, Travis CI & the Github Action)

https://bugs.python.org/issue42142

@E-Paine
Copy link
Contributor Author

E-Paine commented Nov 5, 2020

@terryjreedy or @serhiy-storchaka would you mind please reviewing this PR which will skip the LabeledScaleTest.test_resize and ComboboxTest.test_virtual_event tests when on Ubuntu. As noted, this is only designed as a temporary fix until a more permanent solution for the failures is found.


def ubuntu():
try:
return "Ubuntu" in os.uname().version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice hack 👍

Too bad we don't have os-release support in the platform module. I had a working patch but I closed it after I was harassed by systemd haters.

@E-Paine
Copy link
Contributor Author

E-Paine commented Nov 22, 2020

@serhiy-storchaka please could you review this PR or at least give feedback on the approach used because this issue is clearly annoying others (hence @tiran's report of it)

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like that tests are always skipped on Ubuntu. They are passed successfully on my computer, why should they be skipped?

@E-Paine
Copy link
Contributor Author

E-Paine commented Nov 23, 2020

They are passed successfully on my computer, why should they be skipped?

Because, as far as I can tell, we cannot distinguish between the bots and a 'real' machine. This disabled it on the relevant bots while trying to keep the skips to as small a number of machines as possible (that's why they are skipped on Ubuntu rather than Linux). I agree it is a shame to affect perfectly good machines, and am open to other solutions, but the only other (that doesn't skip the relevant tests) I could come up with was to use threads to timeout wait_visibility gracefully after a second or so.

@tiran
Copy link
Member

tiran commented Nov 24, 2020

I added a parser for freedesktop.org os-release in #23492 . You can use the feature to properly identify Ubuntu and its derivatives: info["ID"] == "ubuntu" or "ubuntu" in info.get("ID_LIKE", ())

@E-Paine E-Paine closed this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants