Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWarn users or provide auto-fix when `frame` is used in a sketch #99
Conversation
| final String undefinedName = args[0]; | ||
| if (undefinedName.equals("frame")) { | ||
| result = Language.interpolate("editor.status.item_removed", undefinedName, "surface"); | ||
| } |
| @@ -1310,6 +1310,12 @@ static public void showChanges() { | |||
| } | |||
| } | |||
|
|
|||
| static public void showChangesV4() { | |||
sampottinger
Jun 29, 2020
Collaborator
Thank you so much for this @urbanskimichal! What are your thoughts on replacing showChanges outright?
sampottinger
Jul 1, 2020
Collaborator
Actually how about doing a showChangesV3 and showChangesV4 (same for handleCrustyCode). See urbanskimichal#2.
sampottinger
added a commit
that referenced
this pull request
Jul 1, 2020
|
I made the above changes ahead of an integration branch build. It's ok if we go a different direction. See urbanskimichal#2. Thank you again @urbanskimichal! |
|
This is available on an integration branch at https://github.com/sampottinger/processing4 ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Work done:
frameoccurs during compilation.Changes in 4.0document.For now I don't think I'm ready for the auto-fix, but can think about it in the future.
This is my first contribution so I'm waiting for suggestions or opinions.