Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadded react_ujs into sources #189
Open
Conversation
| @@ -178,7 +178,7 @@ def when_on_client(&block) | |||
| def send_to_server(*args) | |||
| if IsomorphicHelpers.on_opal_server? | |||
| method_string = "ServerSideIsomorphicMethod." + @name + "(" + args.to_json + ")" | |||
| @result = [JSON.parse(`eval(method_string)`)] | |||
mpantel
May 17, 2019
Author
I suppose @Result = [JSON.parse(eval(method_string))] does nothing? Does it?
|
@mpantel I apologize that I have been behind on reviewing these commits. would you mind trying this in latest hyperstack (edge branch) and seeing if its working there. Unless you really want this fixed in the legacy branch. But otherwise I would like to get everybody on edge and make changes there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #188 for legacy