Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29566: binhex.binhex now consitently writes MacOS 9 line endings. #23059

Merged
merged 1 commit into from Nov 1, 2020

Conversation

ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Oct 31, 2020

bpo-29566 notes that binhex.binhex uses inconsistent line endings (both Unix and MacOS9 line endings are used). This PR changes this to use the MacOS9 line endings everywhere.

https://bugs.python.org/issue29566

Automerge-Triggered-By: GH:ronaldoussoren

@ronaldoussoren ronaldoussoren added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Nov 1, 2020
@miss-islington miss-islington merged commit 2165cea into python:master Nov 1, 2020
10 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 1, 2020

Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Nov 1, 2020

Sorry @ronaldoussoren, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2165cea548f961b308050f30d1f042a377651d44 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 1, 2020
…pythonGH-23059)

[bpo-29566]() notes that binhex.binhex uses inconsistent line endings (both Unix and MacOS9 line endings are used). This PR changes this to use the MacOS9 line endings everywhere.
(cherry picked from commit 2165cea)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 1, 2020

GH-23070 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Nov 1, 2020

Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 1, 2020
…pythonGH-23059)

[bpo-29566]() notes that binhex.binhex uses inconsistent line endings (both Unix and MacOS9 line endings are used). This PR changes this to use the MacOS9 line endings everywhere.
(cherry picked from commit 2165cea)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 1, 2020

GH-23071 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Nov 1, 2020
…dings. (GH-23059) (GH-23070)

[[bpo-29566]()]() notes that binhex.binhex uses inconsistent line endings (both Unix and MacOS9 line endings are used). This PR changes this to use the MacOS9 line endings everywhere.
(cherry picked from commit 2165cea)


Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>

Automerge-Triggered-By: GH:ronaldoussoren
miss-islington added a commit that referenced this pull request Nov 1, 2020
…dings. (GH-23059) (GH-23071)

[[bpo-29566]()]() notes that binhex.binhex uses inconsistent line endings (both Unix and MacOS9 line endings are used). This PR changes this to use the MacOS9 line endings everywhere.
(cherry picked from commit 2165cea)


Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>

Automerge-Triggered-By: GH:ronaldoussoren
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…pythonGH-23059)

[bpo-29566]() notes that binhex.binhex uses inconsistent line endings (both Unix and MacOS9 line endings are used). This PR changes this to use the MacOS9 line endings everywhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-mac 🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants