Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Quantum Full Adder circuit for classical integers #2954

Merged
merged 2 commits into from Nov 11, 2020
Merged

Add Quantum Full Adder circuit for classical integers #2954

merged 2 commits into from Nov 11, 2020

Conversation

@rupansh
Copy link
Contributor

@rupansh rupansh commented Oct 6, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Only ripple_adder has doctests because it is the one intended to be used. The separate functions are there for the ease of explanation and understanding
rupansh added 2 commits Oct 6, 2020
@rupansh
requirements: add qiskit
6923295 
major library required for quantum computing
@rupansh
quantum: add quantum ripple adder implementation
Loading status checks…
07fc7e0 
right now we are essentially performing the same task as a classic ripple adder

Signed-off-by: rupansh-arch <rupanshsekar@hotmail.com>
@rupansh rupansh force-pushed the rupansh:master branch from 6d35ca2 to 07fc7e0 Oct 6, 2020
@poyea poyea self-assigned this Oct 23, 2020
@cclauss
cclauss approved these changes Oct 24, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment

We need to get visitors excited about quantum... It would help if we could help them understand why quantum is better then conventional computing.
@rupansh
Copy link
Contributor Author

@rupansh rupansh commented Oct 24, 2020

We need to get visitors excited about quantum... It would help if we could help them understand why quantum is better then conventional computing.

I will try experimenting with a pure quantum version later. I dont have much experience with quantum computing 😅
@poyea
poyea approved these changes Nov 11, 2020
View changes
Copy link
Member

@poyea poyea left a comment

Thank you for your pull request!🤩
@poyea poyea merged commit 9f6188c into TheAlgorithms:master Nov 11, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@poyea poyea

Assignees

@poyea poyea

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@rupansh @cclauss @poyea
You can’t perform that action at this time.