Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sudoku type hints [Hacktober Fest] #3124

Merged
merged 3 commits into from Oct 10, 2020
Merged

Added sudoku type hints [Hacktober Fest] #3124

merged 3 commits into from Oct 10, 2020
+15 −8

Conversation

@ruppysuppy
Copy link
Member

@ruppysuppy ruppysuppy commented Oct 9, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
ruppysuppy and others added 2 commits Oct 9, 2020
@ruppysuppy
chore(sudoku): added type hints [HACKTOBER-FEST]
67ea423
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
a3549cc
@deadshotsb deadshotsb requested a review from dhruvmanila Oct 10, 2020
@dhruvmanila
dhruvmanila reviewed Oct 10, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment •
edited

I think we should write a type alias for grid as follows:

Matrix = List[List[int]]
@ruppysuppy
chore: added matrix type alias
Loading status checks…
10010df
@ruppysuppy ruppysuppy requested a review from dhruvmanila Oct 10, 2020
@dhruvmanila
dhruvmanila approved these changes Oct 10, 2020
View changes
@dhruvmanila dhruvmanila merged commit 3324bbb into TheAlgorithms:master Oct 10, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ruppysuppy @dhruvmanila
You can’t perform that action at this time.