Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh PR #2216 #3881

Open
wants to merge 18 commits into
base: master
from
Open

Refresh PR #2216 #3881

wants to merge 18 commits into from

Conversation

@crazazy
Copy link

@crazazy crazazy commented Nov 12, 2020

Describe your change:

See #2216

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
crazazy and others added 11 commits Jul 19, 2020
@crazazy
added a faster solution to project euler problem 14
Loading status checks…
b893b86
@crazazy
removed blank line
Loading status checks…
9e62282
@crazazy
switched result type from dict to tuple
Loading status checks…
7efc169
@crazazy
fixed the naming of python variables
Loading status checks…
08fe4a9
@crazazy
fixed typos
Loading status checks…
0cbc3c2 
It's been a while since I worked with typed python, forgive me ok?
@itsvinayak
Update sol3.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
79391d8
@crazazy
un-nested helper functions
e65bb4f
@crazazy
added typehints to all functions
20786f5
@crazazy
added doctests
2118f31 
I am not sure it the calculate_chain doctest works, since they are
testing the side effects of the function, we will see what CI thinks of
it
@crazazy
added the shebang back
Loading status checks…
12d20ff 
noone gave a good reason on why to remove it, and since this file is
executable anyway (and thus easier to run for me)
@crazazy
removed doctests from calculate_chain
Loading status checks…
b45a9d0 
doctests reset the environment after each function evaluation, so we
can't use doctests to inspect side effects of void functions
@crazazy crazazy requested review from dhruvmanila and Kush1101 as code owners Nov 12, 2020
crazazy and others added 6 commits Nov 12, 2020
@crazazy
Merge branch 'master' of https://github.com/TheAlgorithms/Python into…
Loading status checks…
fb1727c 
… master

# Conflicts:
#	project_euler/problem_014/sol3.py
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
2c98623
@crazazy
validate_solutions wants a default parameter for the function
d2924d7
@crazazy
Merge remote-tracking branch 'origin/master' into master
Loading status checks…
3a12ea8
@crazazy
Changed answer format
Loading status checks…
661728f 
Turns out that we don't do any doctests here anymore, we just write our
oWN FRAMEWORK NOW DO WE?!
@crazazy
Fixed doctests
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
33ab2a1
@xcodz-dot
Copy link
Contributor

@xcodz-dot xcodz-dot commented Nov 13, 2020

run the following commands in order:

  • clone your forked repository locally
  • change directory to its root
  • run pip install pre-commit
  • run pre-commit run --all-files twice

commit and push the changes to your fork.
@crazazy
Fixed some pre-commit problems
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bc8c526
@crazazy
Copy link
Author

@crazazy crazazy commented Nov 13, 2020

Consider it fixed
@xcodz-dot
Copy link
Contributor

@xcodz-dot xcodz-dot commented Nov 16, 2020

@dhruvmanila, please check this.
@53jk1
53jk1 approved these changes Nov 19, 2020
View changes
@xcodz-dot
xcodz-dot approved these changes Nov 19, 2020
View changes
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Nov 20, 2020

Thank you for your contribution but currently, we're not accepting solutions to problems that already exist. Try to solve a problem which is not present in the directory and submit a PR for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@53jk1 53jk1

@xcodz-dot xcodz-dot

@Kush1101 Kush1101

@dhruvmanila dhruvmanila

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@crazazy @xcodz-dot @dhruvmanila @53jk1 @itsvinayak
You can’t perform that action at this time.