Skip to content

/ universal

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): add e2e testing #1013

Merged
merged 8 commits into from Jun 10, 2018
Merged

test(e2e): add e2e testing #1013

merged 8 commits into from Jun 10, 2018

Conversation

@CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru commented Jun 9, 2018

No description provided.

@CaerusKaru CaerusKaru added this to To do in Infrastructure via automation Jun 9, 2018
@CaerusKaru CaerusKaru requested a review from vikerman as a code owner Jun 9, 2018
@googlebot googlebot added the cla: yes label Jun 9, 2018
@Toxicable
Toxicable requested changes Jun 9, 2018
View changes
integration/common/package.json Outdated
"@angular/platform-server": "file:../../node_modules/@angular/platform-server",
"@nguniversal/common": "file:../../dist/modules-dist/common",
"@nguniversal/express-engine": "file:../../dist/modules-dist/express-engine",
"express": "^4.14.1",

This comment has been minimized.

Sign in to view
@Toxicable

Toxicable Jun 9, 2018
Contributor

Should use the root version of express
same with all others

This comment has been minimized.

Sign in to view
@CaerusKaru

CaerusKaru Jun 10, 2018
Author Member

Fixed
CaerusKaru added 7 commits Apr 6, 2018
@CaerusKaru
test(e2e): add e2e testing
Loading status checks…
8118d0e
@CaerusKaru
fixup! test(e2e): add e2e testing
Loading status checks…
70e98c9
@CaerusKaru
fixup! test(e2e): add e2e testing
Loading status checks…
c050e2c
@CaerusKaru
fixup! test(e2e): add e2e testing
Loading status checks…
f894328
@CaerusKaru
fixup! test(e2e): add e2e testing
Loading status checks…
50ecdec
@CaerusKaru
fixup! test(e2e): add e2e testing
Loading status checks…
488bb30
@CaerusKaru
fixup! test(e2e): add e2e testing
Loading status checks…
72b77ae
@CaerusKaru CaerusKaru force-pushed the adam/e2e branch from 6a8114f to 72b77ae Jun 10, 2018
@CaerusKaru
fixup! test(e2e): add e2e testing
Loading status checks…
6a02bc2
@Toxicable
Toxicable approved these changes Jun 10, 2018
View changes
@Toxicable Toxicable merged commit 8352730 into master Jun 10, 2018
6 checks passed
6 checks passed
ci/circleci: bazel-lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-packages-dist Your tests passed on CircleCI!
Details
ci/circleci: integration_test Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Infrastructure automation moved this from To do to Done Jun 10, 2018
@Toxicable Toxicable deleted the adam/e2e branch Jun 10, 2018
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Toxicable Toxicable

@vikerman vikerman

Assignees

@Toxicable Toxicable

Labels
action: review cla: yes comp: build comp: ci target: minor
Projects
Infrastructure
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@CaerusKaru @Toxicable @googlebot