Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42333: Port _ssl extension to multiphase initialization (PEP 489) (GH-23253) #23253

Merged
merged 1 commit into from Apr 17, 2021

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 12, 2020

@tiran tiran changed the title bpo-42333: Port ssl module to use heap types and module state bpo-42333: Port _ssl extension to multiphase initialization (PEP 489) Nov 12, 2020
@tiran tiran marked this pull request as ready for review Nov 12, 2020
@tiran tiran force-pushed the ssl_modulestate branch 2 times, most recently from 1e5efb9 to 19a9492 Compare Nov 17, 2020
@tiran tiran requested review from vstinner and corona10 Nov 19, 2020
@github-actions
Copy link

github-actions bot commented Dec 21, 2020

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 21, 2020
@tiran tiran force-pushed the ssl_modulestate branch 2 times, most recently from a51e0ef to 3c63196 Compare Apr 17, 2021
@tiran tiran removed the stale Stale PR or inactive for long period of time. label Apr 17, 2021
- Introduce sslmodule_slots
- Introduce sslmodulestate
- Use sslmodulestate
- Get rid of PyState_FindModule
- Move new structs and helpers to header file
- Use macros to access state
- Keep a strong ref to socket type
@tiran tiran changed the title bpo-42333: Port _ssl extension to multiphase initialization (PEP 489) bpo-42333: Port _ssl extension to multiphase initialization (PEP 489) (GH-23253) Apr 17, 2021
@tiran tiran merged commit 7f1305e into python:master Apr 17, 2021
13 checks passed
@tiran tiran deleted the ssl_modulestate branch Apr 17, 2021
kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
…pythonGH-23253)

- Introduce sslmodule_slots
- Introduce sslmodulestate
- Use sslmodulestate
- Get rid of PyState_FindModule
- Move new structs and helpers to header file
- Use macros to access state
- Keep a strong ref to socket type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants