Skip to content

/ de.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables #9

Merged
merged 6 commits into from Jan 20, 2020
Merged

Variables #9

merged 6 commits into from Jan 20, 2020

Conversation

@JoeGab
Copy link
Contributor

@JoeGab JoeGab commented Jan 19, 2020

No description provided.

JoeGab added 3 commits Jan 19, 2020
@JoeGab
Haupttext und Kommentare übersetzt
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
d152500
@JoeGab
fixed typos
4210d0a
@JoeGab
translate the tasks
Loading status checks…
54fefa2
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-de Jan 19, 2020
@iliakan iliakan mentioned this pull request Jan 19, 2020
Open
11 of 174 tasks complete
@claassistantio
Copy link

@claassistantio claassistantio commented Jan 19, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@JoeGab
Copy link
Contributor Author

@JoeGab JoeGab commented Jan 19, 2020

I didn't create the svg translations, wasn't sure if it is working for those? I also didn't translate the english code snippets except for the descriptional comments. Should I?
@iliakan
Copy link
Member

@iliakan iliakan commented Jan 19, 2020

@JoeGab There's a special way to translate SVGs ;) We can do that later, when more text is ready for publishing.
@JoeGab
Copy link
Contributor Author

@JoeGab JoeGab commented Jan 19, 2020

okay cool! Let me know, I'll help =)
@1H0
1H0 suggested changes Jan 20, 2020
View changes
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jan 20, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
JoeGab and others added 3 commits Jan 20, 2020
@JoeGab @1H0
Update 1-js/02-first-steps/04-variables/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bcb0fc9 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@JoeGab @1H0
Update 1-js/02-first-steps/04-variables/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e1f0e68 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@JoeGab @1H0
Update 1-js/02-first-steps/04-variables/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
912673f 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@JoeGab
Copy link
Contributor Author

@JoeGab JoeGab commented Jan 20, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-de Jan 20, 2020
@1H0
1H0 approved these changes Jan 20, 2020
View changes
@1H0 1H0 merged commit f707218 into javascript-tutorial:master Jan 20, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jan 20, 2020

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
@1H0 1H0 added ready to merge and removed needs +1 labels Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1H0 1H0

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@JoeGab @claassistantio @iliakan @javascript-translate-bot @1H0
You can’t perform that action at this time.