Skip to content

/ de.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of 01-hello-world #4

Merged
merged 2 commits into from Jan 21, 2020
Merged

Translation of 01-hello-world #4

merged 2 commits into from Jan 21, 2020

Conversation

@christianhegedues
Copy link
Member

@christianhegedues christianhegedues commented Jan 12, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-de Jan 12, 2020
@claassistantio
Copy link

@claassistantio claassistantio commented Jan 12, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@mka4975
mka4975 reviewed Jan 16, 2020
View changes
Copy link

@mka4975 mka4975 left a comment

A good translation, the last sentence in 'Summary' should be changed grammatically:
Wir nutzen den Browser als einen Weg um JavaScript auszuführen. Dies ist ein praktischer, da wir online lesen, aber auch nur einer von vielen.
@christianhegedues
Translation of 01-hello-world
Loading status checks…
26787cf
@christianhegedues christianhegedues force-pushed the christianhegedues:de/01-hello-world branch from f251f8f to 26787cf Jan 18, 2020
@christianhegedues
Copy link
Member Author

@christianhegedues christianhegedues commented Jan 18, 2020

Thank you @mka4975 for the hint.
I changed the sentence grammatically and it should be fine for now.
@JoeGab
JoeGab reviewed Jan 20, 2020
View changes
1-js/02-first-steps/01-hello-world/article.md Outdated Show resolved Hide resolved
@christianhegedues @JoeGab
Update 1-js/02-first-steps/01-hello-world/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
07714b3 
Co-Authored-By: Gabriel Jörg <jergo3020@gmail.com>
@christianhegedues
Copy link
Member Author

@christianhegedues christianhegedues commented Jan 20, 2020

/done
@1H0
1H0 approved these changes Jan 21, 2020
View changes
@1H0 1H0 added ready to merge and removed needs +1 labels Jan 21, 2020
@1H0 1H0 merged commit 9a79134 into javascript-tutorial:master Jan 21, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@christianhegedues christianhegedues deleted the christianhegedues:de/01-hello-world branch Feb 10, 2020
javascript-translate-bot pushed a commit that referenced this pull request Mar 24, 2020
@aniketkudale
Merge pull request #4 from javascript-tutorial/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
5a71d10 
Updating Repo 27-01-2020
SirCodewright added a commit to SirCodewright/de.javascript.info that referenced this pull request Apr 5, 2020
@SirCodewright @christianhegedues
Review issues / update javascript-tutorial#4
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
fa2d1aa 
Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeGab JoeGab

@mka4975 mka4975

@1H0 1H0

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@christianhegedues @claassistantio @JoeGab @1H0 @mka4975 @javascript-translate-bot
You can’t perform that action at this time.