Skip to content

pip install --use-feature=2020-resolver #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cclauss wants to merge 1 commit into from
Closed

pip install --use-feature=2020-resolver #3916

cclauss wants to merge 1 commit into from

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Nov 21, 2020

Describe your change:

pip install --use-feature=2020-resolver

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila as a code owner November 21, 2020 08:03
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 21, 2020
@dhruvmanila
Copy link
Member

dhruvmanila commented Nov 21, 2020

I think you branched out from an old commit. I corrected this error in a previous pull request.

@dhruvmanila
Copy link
Member

dhruvmanila commented Nov 21, 2020

Also, maybe add it to the project_euler file as well?

@cclauss cclauss closed this Nov 21, 2020
@dhruvmanila dhruvmanila deleted the cclauss-patch-1 branch October 1, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees

No one assigned

Labels

tests are failing Do not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss @dhruvmanila