Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Base16 Codebase #3534

Merged
merged 2 commits into from Nov 23, 2020
Merged

Improve Base16 Codebase #3534

merged 2 commits into from Nov 23, 2020

Conversation

@tanyonghe
Copy link
Contributor

@tanyonghe tanyonghe commented Oct 19, 2020 •
edited

Changes:

  • Added doctests to increase code coverage as per issue #2128
  • Removed input() usage as discouraged in the Contribution Guidelines

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@tanyonghe
Add doctest and remove input() usage
Loading status checks…
1d6eb49
@github-actions
Copy link

@github-actions github-actions bot commented Nov 18, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@github-actions github-actions bot added the stale label Nov 18, 2020
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Nov 23, 2020

Remove the label.
@stale stale bot removed the stale label Nov 23, 2020
@dhruvmanila
dhruvmanila requested changes Nov 23, 2020
View changes
ciphers/base16.py Outdated Show resolved Hide resolved
ciphers/base16.py Outdated Show resolved Hide resolved
ciphers/base16.py Show resolved Hide resolved
@dhruvmanila
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a86e5b0
@dhruvmanila
dhruvmanila approved these changes Nov 23, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Thank you for your contribution!
@dhruvmanila dhruvmanila merged commit 9bf7b18 into TheAlgorithms:master Nov 23, 2020
2 checks passed
2 checks passed
build
Details
pre-commit
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@tanyonghe @dhruvmanila
You can’t perform that action at this time.